Page MenuHomePhabricator
Create Task
Maniphest T128891

Use OO.ui.alert() instead of plain alert for Thanks error messages
Closed, ResolvedPublic
Actions

Description

			// Fail
			function ( errorCode, details ) {
				// TODO: use something besides alert for the error messages
				switch ( errorCode ) {
					case 'invalidrevision':
						alert( mw.msg( 'thanks-error-invalidrevision' ) );
...

Details

SubjectRepoBranchLines +/-
Use OO.ui.alert() instead of plain alertmediawiki/extensions/Thanksmaster+13 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Mar 4 2016, 6:55 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 4 2016, 6:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Ricordisamoa subscribed.Mar 4 2016, 7:01 PM
Legoktm removed a parent task: T113677: Make OOjs UI in MediaWiki more lightweight, so that we can load it by default on every page without issue.Mar 4 2016, 11:09 PM
Legoktm added a subtask: T113677: Make OOjs UI in MediaWiki more lightweight, so that we can load it by default on every page without issue.
darthbhyrava subscribed.Mar 16 2016, 11:51 PM
• Prtksxna claimed this task.Jul 15 2016, 3:17 PM
gerritbot subscribed.Jul 15 2016, 3:17 PM

Change 299162 had a related patch set uploaded (by Prtksxna):
Use OO.ui.alert() instead of plain alert

https://gerrit.wikimedia.org/r/299162

gerritbot added a project: Patch-For-Review.Jul 15 2016, 3:17 PM
gerritbot added a comment.Jul 19 2016, 9:58 PM

Change 299162 merged by jenkins-bot:
Use OO.ui.alert() instead of plain alert

https://gerrit.wikimedia.org/r/299162

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-26_(1.28.0-wmf.12)).Jul 19 2016, 10:00 PM
Jdforrester-WMF closed subtask T113677: Make OOjs UI in MediaWiki more lightweight, so that we can load it by default on every page without issue as Resolved.Jul 20 2016, 7:09 PM
Catrope closed this task as Resolved.Sep 22 2016, 12:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL