Page MenuHomePhabricator
Create Task
Maniphest T128902

Send more parameters to Maxmind minfraud service
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

Make sure we're using all we can: http://dev.maxmind.com/minfraud/#Input

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Unstage street_address, removing dummy datamediawiki/extensions/DonationInterfacemaster+122 -7
Optionally send more Minfraud parametersmediawiki/extensions/DonationInterfacemaster+154 -59
Upgrade to new minfraud Composer packagemediawiki/extensions/DonationInterfacemaster+655 -233
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Mar 4 2016, 8:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 4 2016, 8:15 PM
gerritbot subscribed.Mar 4 2016, 8:16 PM

Change 275043 had a related patch set uploaded (by Ejegg):
WIP send more Minfraud params

https://gerrit.wikimedia.org/r/275043

gerritbot added a project: Patch-For-Review.Mar 4 2016, 8:16 PM
• DStrine triaged this task as Medium priority.Mar 8 2016, 8:32 PM
• DStrine subscribed.

note: this may help improve our fraud filtering

• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Mar 8 2016, 8:32 PM
• DStrine moved this task from Sprint +1 to Sprint +3 on the Fundraising-Backlog board.Apr 25 2016, 3:47 PM
• DStrine moved this task from Sprint +3 to Triage on the Fundraising-Backlog board.Jul 18 2016, 7:27 PM
• DStrine moved this task from Triage to Q3 2021-2022 on the Fundraising-Backlog board.Jul 18 2016, 8:10 PM
Ejegg added a project: Fundraising Sprint Quill Pencil.Sep 1 2017, 10:25 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Quill Pencil board.
Ejegg changed the point value for this task from 1 to 2.
Ejegg merged tasks: T173876: Try new minfraud features, T172310: spike: New email risk scoring enhancements.Sep 1 2017, 10:27 PM
Ejegg moved this task from Review to Doing on the Fundraising Sprint Quill Pencil board.
Ejegg added subscribers: • Ppena, Nemo_bis, MBeat33, K4-713.
gerritbot added a comment.Sep 1 2017, 10:39 PM

Change 375454 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] WIP upgrade to new Minfraud Composer package

https://gerrit.wikimedia.org/r/375454

Ejegg moved this task from Doing to Review on the Fundraising Sprint Quill Pencil board.Sep 8 2017, 9:50 PM
Ejegg changed the point value for this task from 2 to 4.

This turned out to require upgrading our minFraud SDK and basically rewriting the filter, so I'm upping the point value. On the plus side, the new SDK allows us to actually test with fake HTTP responses.

gerritbot added a comment.Sep 13 2017, 7:13 PM

Change 375454 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Upgrade to new minfraud Composer package

https://gerrit.wikimedia.org/r/375454

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)).Sep 13 2017, 8:01 PM
gerritbot added a comment.Sep 21 2017, 10:25 PM

Change 275043 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Optionally send more Minfraud parameters

https://gerrit.wikimedia.org/r/275043

Ejegg added a project: Fundraising Sprint RadioActivewear.Sep 21 2017, 10:36 PM
Ejegg moved this task from Q3 2021-2022 to Current Sprint and Completed in Q1 2017-18 on the Fundraising-Backlog board.
Ejegg moved this task from Backlog to Done on the Fundraising Sprint RadioActivewear board.Sep 22 2017, 12:48 AM
Ejegg added a comment.Sep 22 2017, 12:51 AM

@Ppena and @MBeat33 this is deployed!

I haven't turned on any of the extra fields yet. Available options are email (send the real address instead of a hash), amount, currency, first_name, last_name, and street_address.

• DStrine added a project: Fundraising Sprint Synchronized Screaming.Sep 26 2017, 8:46 PM
Ejegg moved this task from Backlog to Done on the Fundraising Sprint Synchronized Screaming board.Sep 26 2017, 9:15 PM
Ejegg moved this task from Done to Review on the Fundraising Sprint Synchronized Screaming board.Sep 27 2017, 4:59 PM
gerritbot added a comment.Sep 27 2017, 4:59 PM

Change 381037 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Unstage street_address, removing dummy data

https://gerrit.wikimedia.org/r/381037

gerritbot added a comment.Sep 27 2017, 5:10 PM

Change 381037 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Unstage street_address, removing dummy data

https://gerrit.wikimedia.org/r/381037

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)).Sep 27 2017, 6:00 PM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Synchronized Screaming board.Sep 27 2017, 6:03 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Synchronized Screaming board.Sep 27 2017, 7:54 PM
Ejegg closed this task as Resolved.Sep 27 2017, 7:57 PM

Sending them! And now not sending dummy data when we don't have postal code or street address.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits