Page MenuHomePhabricator

Change #Phabricator-Upstream into a milestone of #Phabricator
Closed, ResolvedPublic

Description

Proposal:
To improve the visibility of upstream issues (issues with Phabricator itself, not specifically our config or instance) in Phabricator we should turn Phabricator (Upstream) into a milestone of Phabricator.

Good Things(TM):

  • More visibility (the tasks would be visible on the Phabricator workboard)
    • This hopefully means fewer duplicate reports

Not Great Things(TM):

  • A "milestone" isn't really what these are
    • But that's just my (@greg's) semantic/metadata nerd side complaining

Event Timeline

Why not make Phabricator (Upstream) a subproject at phabricator? Alternativly, I we want to have a column with this name in Phabricator, we can make Phabricator (Upstream) to a milestone, so it is shown at the workboard of Phabricator. What do you think?

Definitely not a milestone, but maybe a sub-project. Maybe Phabricator (Upstream). I just want to make sure that people see the "upstream" tasks before they report duplicates (as happens a lot).

(Also, I just confirmed playing with phab-01.wmflabs.org that my previous assumption was incorrect: If you have a project and you create a sub project you can have tasks in both the parent the child. I was under the impression at first that all tasks in the parent were moved to the child.)

Maybe a milestone? ugh, not sure. I only said "definitely not" because, well, it's not a "milestone" in the semantic sense and my semantic tingly sense perks up when I see things like that :) The milestone would give us the tasks on the main Phabricator workboard, which means people might seem them more easily than them being only in the Phabricator (Upstream) (subproject) workboard.

Why not make Phabricator (Upstream) a subproject at phabricator?

What would be the gain?

We have one project for one thing. Not a tag, where you have to search for the right column, which means, that you can't search with the normal advanced query, you have to use the query at the workboard of Upstream. In my opinion a good advantage.

There is one additional reason. From the description:

(all -Upstream tasks are in fact valid Phabricator issues as well).

That's the intention of a subproject, why this was made for.

Making Phabricator (Upstream) into a milestone of Phabricator would probably make sense.

You can see how milestones work by looking at the right side of the workboard in Scap

Making Phabricator (Upstream) into a milestone of Phabricator would probably make sense.

You can see how milestones work by looking at the right side of the workboard in Scap

And when you search in Maniphest for tasks in Scap you get:
https://phabricator.wikimedia.org/maniphest/query/qKwdzxOyAdDY/#R

Which includes the tasks in the milestones.

The same happens for sub-projects though:
https://phab-01.wmflabs.org/maniphest/query/hsJm_4jHydWs/#R

The benefit is you see all tasks in the parent project's workboard when you use Milestones versus when you use sub-projects (see eg: https://phab-01.wmflabs.org/tag/project_-_greg_grossmeier/ )

I'm leaning towards a milestone called Phabricator (Upstream) (only problem is without database fiddling, I'll need to do some fancy footwork to create the new milestone and move tasks over to it from the current project, not a huge deal).

greg lowered the priority of this task from Medium to Low.Mar 22 2016, 8:45 PM

If agreement is to create a milestone for "upstream" (instead of sub-project), could someone update the steps in this task's description accordingly?
That would in theory allow to steal this task from @greg (not that I'd ever do such things). :P

greg removed greg as the assignee of this task.Mar 23 2016, 5:45 PM

:) (sorry, things got in my way :( )

greg renamed this task from Deprecate #Phabricator-Upstream and use #Phabricator + #Upstream instead to Change #Phabricator-Upstream into a milestone of #Phabricator.Apr 2 2016, 12:14 AM
greg updated the task description. (Show Details)

Wondering if "Turn Phabricator (Upstream) into a milestone subproject of "Phabricator" so all Phabricator (Upstream) tasks will be displayed in one column on the Phabricator board but all Phabricator (Upstream) tasks will also remain in their specific Phabricator (Upstream) workboard column." could be done server-side (instead of moving large amounts of tasks around between projects and workboard columns).

With the knowledge we have today, I believe a "subproject" is more accurate than a "milestone" and it will provide the same features in terms of integration with Phabricator and its workboard.

With the knowledge we have today, I believe a "subproject" is more accurate than a "milestone" and it will provide the same features in terms of integration with Phabricator and its workboard.

But:

Making Phabricator (Upstream) into a milestone of Phabricator would probably make sense.

You can see how milestones work by looking at the right side of the workboard in Scap

And when you search in Maniphest for tasks in Scap you get:
https://phabricator.wikimedia.org/maniphest/query/qKwdzxOyAdDY/#R

Which includes the tasks in the milestones.

The same happens for sub-projects though:
https://phab-01.wmflabs.org/maniphest/query/hsJm_4jHydWs/#R

The benefit is you see all tasks in the parent project's workboard when you use Milestones versus when you use sub-projects (see eg: https://phab-01.wmflabs.org/tag/project_-_greg_grossmeier/ )

I'm leaning towards a milestone called Phabricator (Upstream) (only problem is without database fiddling, I'll need to do some fancy footwork to create the new milestone and move tasks over to it from the current project, not a huge deal).

greg moved this task from Backlog to Needs Review / Blocked / Waiting on the User-greg board.

With the knowledge we have today, I believe a "subproject" is more accurate than a "milestone" and it will provide the same features in terms of integration with Phabricator and its workboard.

Really? I thought only milestones got their own workboard columns.

I'm leaning towards a milestone called Phabricator (Upstream) (only problem is without database fiddling, I'll need to do some fancy footwork to create the new milestone and move tasks over to it from the current project, not a huge deal).

I can convert it by simply running the migration script on iridium.

I can convert it by simply running the migration script on iridium.

+1 from me

mmodell claimed this task.