Page MenuHomePhabricator

reflinks.py doesn't check existing "autogenerated" tags
Open, Needs TriagePublic

Description

For example, have a look at the diff:
https://ru.wikipedia.org/w/index.php?title=%D0%AD%D0%BA%D0%BE%D0%BD%D0%BE%D0%BC%D0%B8%D0%BA%D0%B0_%D0%A3%D0%BA%D1%80%D0%B0%D0%B8%D0%BD%D1%8B&diff=76293350&oldid=76247022

The bot assigned ref-tags "autogenerated2", "autogenerated3", "autogenerated4" but those refnames were already used in the article and that resulted in the error - the same refname assigned to different links.

Fortunately, the bot fix it itself during the next edits:
https://ru.wikipedia.org/w/index.php?title=%D0%AD%D0%BA%D0%BE%D0%BD%D0%BE%D0%BC%D0%B8%D0%BA%D0%B0_%D0%A3%D0%BA%D1%80%D0%B0%D0%B8%D0%BD%D1%8B&diff=76341806&oldid=76293350

https://ru.wikipedia.org/w/index.php?title=%D0%AD%D0%BA%D0%BE%D0%BD%D0%BE%D0%BC%D0%B8%D0%BA%D0%B0_%D0%A3%D0%BA%D1%80%D0%B0%D0%B8%D0%BD%D1%8B&diff=76381201&oldid=76341806

But I think it will be more correct to check existing refnames before they are assigned by the script

Event Timeline

Rubin16 created this task.Mar 5 2016, 1:45 PM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptMar 5 2016, 1:45 PM
Dalba removed a subscriber: Pywikibot.Mar 5 2016, 1:51 PM
id = 1
while self.autogen + str(id) in foundRefNames:
    id += 1