Maniphest T129098

UI of lazy loaded smaller images is distracting
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Mar 7 2016, 5:30 PM

Tags

Referenced Files

	F3337097: Screen Shot 2016-02-12 at 10.03.26 AM.png
	Mar 7 2016, 5:30 PM

Subscribers

View All 14 Subscribers

Description

See:

Screen Shot 2016-02-12 at 10.03.26 AM.png (344×544 px, 64 KB)

When an image is less than 80px do not show a spinner.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Don't serve spinner in raw HTML	mediawiki/extensions/MobileFrontend	master	+12 -15

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
		Open		None	T50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
		Open		None	T54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
		Open		None	T396539 Introduce a way to edit a span of text from within read mode
		Open		None	T385558 Improve copy and paste from read mode to VE
		Open		None	T174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
		Open	Feature	None	T54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
		Open		None	T55784 [EPIC] Use Parsoid HTML for all page views
		Resolved		dr0ptp4kt	T114542 Next Generation Content Loading and Routing, in Practice
		Duplicate		• Jhernandez	T104432 [EPIC]: Improve mobile site performance
		Duplicate		dr0ptp4kt	T120341 [GOAL] Make Wikipedia more accessible to all connections with new fast API-driven web experience in mobile web beta
		Declined		None	T125920 [EPIC] Future exciting reading web performance endeavours
		Resolved		Jdlrobson	T113066 [GOAL] Make Wikipedia more accessible to 2G connections
		Resolved		Jdlrobson	T124390 [GOAL] Load images with care
		Resolved		Jdlrobson	T129098 UI of lazy loaded smaller images is distracting

Event Timeline

Jdlrobson created this task.Mar 7 2016, 5:30 PM

Jdlrobson updated the task description. (Show Details)Mar 7 2016, 5:39 PM

If the images are less than 80px width OR 80px height, the spinner should not be shown. the placeholder would be just the grey box.

dr0ptp4kt removed a project: Reading-Admin.Mar 10 2016, 7:49 PM

dr0ptp4kt added a project: MobileFrontend.Mar 10 2016, 11:39 PM

• Nirzar removed • Nirzar as the assignee of this task.Mar 12 2016, 12:13 AM

Jdlrobson set the point value for this task to 1.Mar 12 2016, 12:50 AM

Jdlrobson updated the task description. (Show Details)Mar 14 2016, 4:28 PM

Jdlrobson removed a project: Reading-Web-Sprint-65-Game of Phones.

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.Mar 14 2016, 4:31 PM

• jhobs claimed this task.Mar 15 2016, 12:09 AM

Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.Mar 15 2016, 12:12 AM

I accidentally fixed this as part of some other work. Will post patch shortly.

In T129098#2123709, @Jdlrobson wrote:

I accidentally fixed this as part of some other work. Will post patch shortly.

HOW DARE YOU! ;)

Change 277568 had a related patch set uploaded (by Jdlrobson):
Don't serve spinner in raw HTML

https://gerrit.wikimedia.org/r/277568

gerritbot added a project: Patch-For-Review.Mar 15 2016, 7:04 PM

• jhobs reassigned this task from • jhobs to Jdlrobson.Mar 15 2016, 7:04 PM

• jhobs subscribed.

Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.Mar 15 2016, 7:08 PM

• bmansurov moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.Mar 15 2016, 9:24 PM

Change 277568 merged by jenkins-bot:
Don't serve spinner in raw HTML

https://gerrit.wikimedia.org/r/277568

Verified on http://reading-web-staging.wmflabs.org/wiki/TestBlah#Section_A

Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.Mar 16 2016, 12:05 AM