Page MenuHomePhabricator

SET: User last editor is not being set in the wikitext editor unless the user switches there
Closed, ResolvedPublic1 Story Points

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2016, 8:28 PM
Krinkle added a subscriber: Krinkle.Mar 7 2016, 8:40 PM

I experienced the same in Beta labs and locally. Once the SET feature is enabled in VisualEditor, the Edit tab defaults to VisualEditor. Contrary to @Tgr's comment at T128780 this is not because it defaults to "Always VE". It defaults to the "Last used editor" logic as intended just fine.

However there appears to be a small logic issue in how SET determines "Last used editor".

The "last used editor" tracking did not exist prior to the introduction of the SET feature. As such, the system doesn't know what I used last. And it appears that in the absence of a "VEE=wikitext" cookie (which nobody has) VisualEditor is the fallback. And as such, it is effectively the default.

Users will see VE at least once after enabling SET on a wiki and gets the dialog there to confirm the "Use last used editor" dialog. At which point they then have to manually switch to source mode. And it'll be remembered from that point forward.

This isn't bad, but I'm just uncertain whether that was the plan (expose everyone to VE one last time and then remember it going forward - ignoring any previous preferences or last used editor before this point).

It also isn't trivial to do right either since short of inspecting the revision history change tags, we can't really bootstrap a sensible default in absence of a VEE cookie.

Why doesn't anyone have these? I thought that these cookies were supposed to have been collected for IPs since approximately December. I also thought that it was a pref, rather than a cookie, for logged-in editors (and collected just as long).

@Whatamidoing-WMF Yeah, just chatted with @Jdforrester-WMF. It seems the plan did account for it, but it fell through the cracks somehow.

The last used editor cookie (VEE) is only set by VisualEditor when switching to source mode from within VisualEditor itself. When loading "Edit source" (WikiEditor) directly it isn't set (but should've been).

Change 275619 had a related patch set uploaded (by Jforrester):
Follow-up I65d96627: Remember the user's preference in WikiEditor too

https://gerrit.wikimedia.org/r/275619

Jdforrester-WMF renamed this task from SET: Opening editor after SET is enabled is ignoring user last editor and using the site default, for one user to SET: User last editor is not being set in the wikitext editor unless the user switches there.Mar 7 2016, 8:56 PM
Jdforrester-WMF changed the task status from Stalled to Open.
Jdforrester-WMF claimed this task.
Jdforrester-WMF raised the priority of this task from High to Unbreak Now!.

Change 275619 merged by jenkins-bot:
Follow-up I65d96627: Remember the user's preference in WikiEditor too

https://gerrit.wikimedia.org/r/275619

Change 275693 had a related patch set uploaded (by Jforrester):
Follow-up I65d96627: Remember the user's preference in WikiEditor too

https://gerrit.wikimedia.org/r/275693

Change 275693 merged by jenkins-bot:
Follow-up I65d96627: Remember the user's preference in WikiEditor too

https://gerrit.wikimedia.org/r/275693