Page MenuHomePhabricator
Create Task
Maniphest T129162

ActionWidget probably doesn't need to emit 'resize' events
Closed, ResolvedPublic
Actions

Description

ActionWidget probably doesn't need to emit 'resize' events.

This dates back to rGOJU3ba36b9a53aa: [BREAKING CHANGE] The great and terrible dialog refactor and I can't find any evidence of it being ever used (not even in that patch, and not in that patch's history). Maybe @TrevorParscal remembers. But we could probably axe it. (It's going to be technically a breaking change, though.)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[BREAKING CHANGE] ActionWidget: Remove resize eventoojs/uimaster+0 -105
ActionWidget/Set: Warn deprecation for methods using the 'resize' eventoojs/uimaster+9 -2
Remove event listening code for ActionWidget's 'resize' eventoojs/uimaster+0 -29
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Mar 7 2016, 9:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2016, 9:43 PM
Jdforrester-WMF triaged this task as Medium priority.Mar 22 2016, 6:26 PM
Danny_B moved this task from Unsorted to Needs research on the Technical-Debt board.May 6 2016, 12:42 AM
• Prtksxna added projects: good first task, Google-Code-In-2016.Nov 3 2016, 8:05 AM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptNov 3 2016, 8:05 AM
• Prtksxna subscribed.Nov 3 2016, 8:05 AM

I will mentor this in Google-Code-In-2016

Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Nov 27 2016, 9:57 PM

Imported as https://codein.withgoogle.com/tasks/5665996887031808/

gerritbot subscribed.Dec 19 2016, 11:32 PM

Change 328308 had a related patch set uploaded (by IvanFon):
Removed resize event from ActionWidget.js

https://gerrit.wikimedia.org/r/328308

gerritbot added a project: Patch-For-Review.Dec 19 2016, 11:32 PM
IvanFon claimed this task.Dec 19 2016, 11:58 PM
Volker_E moved this task from Backlog to Doing on the OOUI board.Dec 20 2016, 5:02 PM
Aklapper added a comment.Dec 21 2016, 3:27 AM

Could https://gerrit.wikimedia.org/r/328308 get a review please? Thanks!

matmarex added a comment.Dec 21 2016, 7:53 AM

@Aklapper: Reviewed.

Note that we might not be able to merge the patch right now, it's technically a breaking change (even though I don't think anything relied on this feature), so we'll do some deprecation/announcement first. But after my comments are addressed, the coding work will be complete.

matmarex added a comment.Dec 27 2016, 12:29 PM

@IvanFon Thanks for working on this!

@Aklapper If this work was for a GCI task, it can be considered done. We just can't merge the change until the next major release (probably, it's James' decision and he's on vacation).

gerritbot added a comment.Feb 8 2017, 9:25 AM

Change 336594 had a related patch set uploaded (by Prtksxna):
ActionWidget: Add depracation warnings for methods using the reszive event

https://gerrit.wikimedia.org/r/336594

gerritbot added a comment.Feb 10 2017, 7:38 AM

Change 336965 had a related patch set uploaded (by Prtksxna):
ActionWidget: Add deprecation warnings for methods using the 'resize' event

https://gerrit.wikimedia.org/r/336965

gerritbot added a comment.Feb 10 2017, 2:45 PM

Change 336594 merged by jenkins-bot:
Remove event listening code for ActionWidget's 'resize' event

https://gerrit.wikimedia.org/r/336594

gerritbot added a comment.Mar 11 2017, 10:10 PM

Change 336965 merged by jenkins-bot:
[oojs/ui] ActionWidget/Set: Warn deprecation for methods using the 'resize' event

https://gerrit.wikimedia.org/r/336965

• Prtksxna mentioned this in E540: Remove 'resize' events from ActionWidget/Set.Mar 12 2017, 5:07 AM
gerritbot added a comment.Apr 10 2017, 10:58 AM

Change 328308 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] ActionWidget: Remove resize event

https://gerrit.wikimedia.org/r/328308

Volker_E moved this task from Doing to OOjs-UI-0.21.0 on the OOUI board.Apr 18 2017, 8:56 AM
Volker_E edited projects, added OOUI (OOjs-UI-0.21.0); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.
Volker_E subscribed.

Thanks @IvanFon for your contribution!

Volker_E closed this task as Resolved.Oct 17 2017, 8:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits