Page MenuHomePhabricator

increase $wgAbuseFilterConditionLimit for dewiki
Closed, InvalidPublic

Description

At dewiki we have problems with many filters that seem to be inactive. Unfortunately I don't have a clue, how to debug such a problem. However, we think that an higher $wgAbuseFilterConditionLimit could solve the problem.

Event Timeline

seth created this task.Mar 7 2016, 10:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2016, 10:32 PM
Glaisher added a subscriber: Glaisher.

Increasing that limit will probably have adverse impacts on performance. If there is a problem with condition limit, you should see whether there is room for improvement in the filters before changing this.

Also are you actually sure that there are changes which should have matched these filters before considering that it's a technical problem?

Restricted Application added subscribers: JEumerus, Matanya. · View Herald TranscriptMar 8 2016, 10:35 AM

See https://www.mediawiki.org/wiki/Extension:AbuseFilter/Conditions for more background.

What we could do is to increase the limit 24 hours, and measure impact.

seth added a comment.EditedMar 8 2016, 10:22 PM

If there is a problem with condition limit, you should see whether there is room for improvement in the filters before changing this.

Already done (long before I started this request).

Also are you actually sure that there are changes which should have matched these filters [...]

yes, several times during the last year. Although I don't know, whether the condition limit is reached, because I can't see any hint on that. (Formerly there was a message per rule saying how many conditions in average it took. But this messages seemed to be like random number and I guess that's the reason why they have vanished.)

Maybe better than trying out something for a few hours would be some measuring of the reached conditions over time. Is that possible? Is there a log of number of conditions per time/edit?

Restricted Application added a subscriber: Luke081515. · View Herald TranscriptMar 9 2016, 8:53 PM

@Gilles would a 24 hours test per T129171#2098988 be acceptable?

Poyekhali triaged this task as Medium priority.Apr 13 2016, 3:35 AM
Gilles added a subscriber: aaron.Apr 13 2016, 11:19 AM

I think @aaron will have a more formed opinion than me on the matter, I've never been around that code.

This might no longer be necessary after my recent fixes to the way conditions are counted (which generally decreased the number of conditions used by most filters), see longer explanation at T132048#2212440. https://de.wikipedia.org/wiki/Spezial:Missbrauchsfilter is currently saying that 0 recent actions exceeded the limit (but this doesn't tell is much due to T132925).

It's also always possible that there are mistakes in the filters which cause them not to match. ;)

(Formerly there was a message per rule saying how many conditions in average it took. But this messages seemed to be like random number and I guess that's the reason why they have vanished.)

This can be re-enabled now on a per-wiki basis, at least temporarily (I'm not sure how big is the performance impact of recording this data on every action, but it's probably better not to leave it on forever). See a similar change for Commons in T132200.

Another option is to enable $wgAbuseFilterProfile for dewiki to help them identify which filters are so condition-demanding and have them tweaked. I was adviced in a recent request to raise the condition limit of Meta-Wiki to try that first.

If dewiki thinks there is a problem, I support profiling enabling first to debug it and if all filters are needed, then this variable can be raised.

Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.

@seth Can you please confirm that this is still a problem? Thanks.

seth added a comment.Feb 22 2018, 6:41 PM

Hi!
Sorry, but I can't confirm, because during the last months I used the edit filter very(!) rarely. (So I can't confirm the opposite, too.)

matej_suchanek changed the task status from Open to Stalled.Mar 3 2018, 4:16 PM
Daimona closed this task as Invalid.Mar 28 2018, 8:40 PM
Daimona added a subscriber: Daimona.

Looking at the grafana dashboard, which was recently enabled for dewiki, I see an average of 350 used conditions. This means that this change shouldn't be needed anymore.

matmarex removed a subscriber: matmarex.Apr 5 2018, 5:15 PM