Page MenuHomePhabricator
Create Task
Maniphest T129200

Only show one of the SET-two-tabs dialog (for returning editors) and the VE-welcome-dialog (for newbie editors)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Showing both is bad, and the wrong way around; if they're an existing editor we'd not really need to show them the 'welcome' dialog, so let's not.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Suppress welcome dialog this time if we're showing the SET pref dialogmediawiki/extensions/VisualEditormaster+23 -6
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Mar 8 2016, 12:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2016, 12:44 AM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Mar 8 2016, 1:54 AM
Jdforrester-WMF merged a task: T129048: Let me set my prefs from the dialog before switching to the wikitext editor.Mar 8 2016, 1:58 AM
Jdforrester-WMF added a subscriber: • Whatamidoing-WMF.
• AlexMonk-WMF claimed this task.Mar 9 2016, 9:03 PM
gerritbot subscribed.Mar 9 2016, 9:03 PM

Change 276268 had a related patch set uploaded (by Alex Monk):
Suppress welcome dialog this time if we're showing the SET pref dialog

https://gerrit.wikimedia.org/r/276268

gerritbot added a project: Patch-For-Review.Mar 9 2016, 9:03 PM
• AlexMonk-WMF added a comment.Mar 9 2016, 9:04 PM

see todo in commit message

Jdforrester-WMF closed this task as Resolved.Mar 10 2016, 8:27 PM
gerritbot added a comment.Mar 10 2016, 8:38 PM

Change 276268 merged by jenkins-bot:
Suppress welcome dialog this time if we're showing the SET pref dialog

https://gerrit.wikimedia.org/r/276268

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-15_(1.27.0-wmf.17)).Mar 14 2016, 10:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits