see changes in https://gerrit.wikimedia.org/r/#/c/275796/
the current SpaceyParenthesisSniff can't fix below as the comments say.
wffoo( $a, $b ); wffoo( $a, $b );
and just fix
wffoo( $a,$b); wffoo( ); wffoo($a, $b);
see changes in https://gerrit.wikimedia.org/r/#/c/275796/
the current SpaceyParenthesisSniff can't fix below as the comments say.
wffoo( $a, $b ); wffoo( $a, $b );
and just fix
wffoo( $a,$b); wffoo( ); wffoo($a, $b);
Hi! I have problems to parse/understand this task's summary... What is the problem this task is actually about? Or is the task summary simply missing some punctuation and the "Can't..." stuff is a different sentence?
Also, to automatically get a link in this task to https://gerrit.wikimedia.org/r/#/c/275796/ by Gerritbot, please follow https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines - thanks!
@Aklapper Sorry,I input two space acturally. I don't know the reason why it just display single space :P
Oh,thanks for you reminder of Gerrit ,I will follow it :)
@Lethexie: Please explain why you closed this task as RESOLVED. The patch in https://gerrit.wikimedia.org/r/#/c/275796/ is not merged yet.
@Aklapper Should it be closed as RESOLVED util a patch is merged ? I thought mistakenly that it can be changed to RESOLVED once a patch had been submitted.
See https://www.mediawiki.org/wiki/Bug_management/Bug_report_life_cycle - if no code has been merged, nothing has been resolved for anybody...
I still don't know what "the bug" is in the summary of this task. Most tasks in Phabricator are about bugs so this feels vague... :)