Page MenuHomePhabricator

test_WbMonolingualText_invalid_text failing
Closed, ResolvedPublic

Description

A dot (period) was added recently to a wikibase error message? The following appears on our test.wikidata builds with edit failures enabled: https://travis-ci.org/jayvdb/pywikibot-core/jobs/114591756

======================================================================
FAIL: Attempt adding a monolingual text with an invalid non-string text.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/jayvdb/pywikibot-core/tests/edit_failure_tests.py", line 156, in test_WbMonolingualText_invalid_text
    item.addClaim, claim)
  File "/home/travis/build/jayvdb/pywikibot-core/tests/aspects.py", line 292, in assertAPIError
    code, info, msg, self).handle(callable_obj, args, kwargs)
  File "/home/travis/build/jayvdb/pywikibot-core/tests/utils.py", line 303, in handle
    callable_obj(*args, **kwargs)
  File "/home/travis/build/jayvdb/pywikibot-core/tests/utils.py", line 295, in __exit__
    self.test_case.assertEqual(exc_value.info, self.info)
nose.proxy.AssertionError: 'Invalid snak. (Can only construct a MonolingualTextValue with a string value.)' != 'Invalid snak (Can only construct a MonolingualTextValue with a string value.)'
- Invalid snak. (Can only construct a MonolingualTextValue with a string value.)
?             -
+ Invalid snak (Can only construct a MonolingualTextValue with a string value.)

Event Timeline

jayvdb created this task.Mar 8 2016, 8:55 PM
jayvdb added a comment.Mar 8 2016, 9:37 PM

fwiw, the test was added for T123856

Change 276104 had a related patch set uploaded (by Xqt):
[testfix] Fix wikibase error message

https://gerrit.wikimedia.org/r/276104

Xqt claimed this task.Mar 9 2016, 7:43 AM

Change 276104 merged by jenkins-bot:
[testfix] Fix wikibase error message

https://gerrit.wikimedia.org/r/276104

jayvdb closed this task as Resolved.Mar 9 2016, 8:19 AM