Page MenuHomePhabricator

Missing currency code in mustache form gives vague, non-localized error message
Closed, ResolvedPublic1 Story Points

Description

When testing https://gerrit.wikimedia.org/r/275023, @AndyRussG found that omitting the currency code in a Spanish form link showed "An error occurred processing your request" instead of a currency-specific or amount-specific message in Spanish.

Event Timeline

Ejegg created this task.Mar 8 2016, 9:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2016, 9:18 PM

Change 275934 had a related patch set uploaded (by Ejegg):
Ensure $results is defined before use

https://gerrit.wikimedia.org/r/275934

Change 276014 had a related patch set uploaded (by Ejegg):
Fix bug so we use invalid amount error

https://gerrit.wikimedia.org/r/276014

Change 276016 had a related patch set uploaded (by Ejegg):
Partial fix for busted check that a translation exists

https://gerrit.wikimedia.org/r/276016

Change 276017 had a related patch set uploaded (by Ejegg):
Show an invalid amount message on missing currency

https://gerrit.wikimedia.org/r/276017

Change 275934 merged by jenkins-bot:
Ensure $results is defined before use

https://gerrit.wikimedia.org/r/275934

Change 276016 merged by jenkins-bot:
Partial fix for busted check that a translation exists

https://gerrit.wikimedia.org/r/276016

Change 276014 merged by jenkins-bot:
Fix bug so we use invalid amount error

https://gerrit.wikimedia.org/r/276014

Ejegg closed this task as Resolved.Mar 16 2016, 10:17 PM

The error message is now localized, but we should add a specific message to review the donation amount because no currency was provided.

Change 276017 abandoned by Ejegg:
Show an invalid amount message on missing currency

https://gerrit.wikimedia.org/r/276017