Page MenuHomePhabricator
Create Task
Maniphest T129277

Missing currency code in mustache form gives vague, non-localized error message
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When testing https://gerrit.wikimedia.org/r/275023, @AndyRussG found that omitting the currency code in a Spanish form link showed "An error occurred processing your request" instead of a currency-specific or amount-specific message in Spanish.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Show an invalid amount message on missing currencymediawiki/extensions/DonationInterfacemaster+9 -3
Fix bug so we use invalid amount errormediawiki/extensions/DonationInterfacemaster+9 -10
Partial fix for busted check that a translation existsmediawiki/extensions/DonationInterfacemaster+4 -4
Ensure $results is defined before usemediawiki/extensions/DonationInterfacemaster+1 -0
Customize query in gerrit

Event Timeline

Ejegg created this task.Mar 8 2016, 9:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2016, 9:18 PM
gerritbot subscribed.Mar 8 2016, 9:37 PM

Change 275934 had a related patch set uploaded (by Ejegg):
Ensure $results is defined before use

https://gerrit.wikimedia.org/r/275934

gerritbot added a project: Patch-For-Review.Mar 8 2016, 9:37 PM
gerritbot added a comment.Mar 8 2016, 10:24 PM

Change 276014 had a related patch set uploaded (by Ejegg):
Fix bug so we use invalid amount error

https://gerrit.wikimedia.org/r/276014

gerritbot added a comment.Mar 8 2016, 10:28 PM

Change 276016 had a related patch set uploaded (by Ejegg):
Partial fix for busted check that a translation exists

https://gerrit.wikimedia.org/r/276016

gerritbot added a comment.Mar 8 2016, 10:36 PM

Change 276017 had a related patch set uploaded (by Ejegg):
Show an invalid amount message on missing currency

https://gerrit.wikimedia.org/r/276017

gerritbot added a comment.Mar 8 2016, 11:26 PM

Change 275934 merged by jenkins-bot:
Ensure $results is defined before use

https://gerrit.wikimedia.org/r/275934

gerritbot added a comment.Mar 8 2016, 11:39 PM

Change 276016 merged by jenkins-bot:
Partial fix for busted check that a translation exists

https://gerrit.wikimedia.org/r/276016

Ejegg moved this task from Backlog to Review on the Fundraising Sprint Elevator Maintenance 2016 board.Mar 8 2016, 11:46 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-15_(1.27.0-wmf.17)).Mar 9 2016, 12:00 AM
gerritbot added a comment.Mar 9 2016, 12:36 AM

Change 276014 merged by jenkins-bot:
Fix bug so we use invalid amount error

https://gerrit.wikimedia.org/r/276014

• DStrine moved this task from Triage to Current Sprint & Completed in Q3 1516 on the Fundraising-Backlog board.Mar 10 2016, 7:28 PM
Ejegg moved this task from Review to Done on the Fundraising Sprint Elevator Maintenance 2016 board.Mar 11 2016, 1:35 AM
Ejegg closed this task as Resolved.Mar 16 2016, 10:17 PM

The error message is now localized, but we should add a specific message to review the donation amount because no currency was provided.

gerritbot added a comment.Aug 10 2016, 9:46 PM

Change 276017 abandoned by Ejegg:
Show an invalid amount message on missing currency

https://gerrit.wikimedia.org/r/276017

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits