Page MenuHomePhabricator
Create Task
Maniphest T129376

Catch exceptions in adapter constructor
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

GatewayPage has a top-level exception handler around handleRequest, but nothing around adapter construction, so exceptions there bomb out. We should catch them, log them properly, and show the donors a reasonable fail page.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Tests for new ResultPages functionsmediawiki/extensions/DonationInterfacemaster+18 -0
Catch and log errors in adapter constructorsmediawiki/extensions/DonationInterfacemaster+86 -69
Enable fail page without adapter instancemediawiki/extensions/DonationInterfacemaster+72 -21
Get a better logger without adapter instancemediawiki/extensions/DonationInterfacemaster+57 -16
Customize query in gerrit

Event Timeline

Ejegg created this task.Mar 9 2016, 5:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2016, 5:55 PM
gerritbot subscribed.Mar 9 2016, 5:56 PM

Change 276218 had a related patch set uploaded (by Ejegg):
Enable fail page without adapter instance

https://gerrit.wikimedia.org/r/276218

gerritbot added a project: Patch-For-Review.Mar 9 2016, 5:56 PM
Ejegg added a project: Fundraising-Backlog.Mar 9 2016, 5:56 PM
gerritbot added a comment.Mar 9 2016, 6:12 PM

Change 276222 had a related patch set uploaded (by Ejegg):
WIP catch errors in adapter constructors

https://gerrit.wikimedia.org/r/276222

Ejegg added projects: Unplanned-Sprint-Work, Fundraising Sprint Elevator Maintenance 2016.Mar 9 2016, 7:09 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Elevator Maintenance 2016 board.
• DStrine moved this task from Triage to Current Sprint & Completed in Q3 1516 on the Fundraising-Backlog board.Mar 10 2016, 7:28 PM
• DStrine added a project: Fundraising Sprint Freshmaking.Mar 16 2016, 10:55 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Freshmaking board.Mar 16 2016, 11:07 PM
Ejegg moved this task from Review to Doing on the Fundraising Sprint Freshmaking board.Mar 18 2016, 6:09 PM
gerritbot added a comment.Mar 18 2016, 7:07 PM

Change 278335 had a related patch set uploaded (by Ejegg):
Get a better logger without adapter instance

https://gerrit.wikimedia.org/r/278335

Ejegg moved this task from Doing to Review on the Fundraising Sprint Freshmaking board.Mar 18 2016, 7:31 PM
gerritbot added a comment.Mar 18 2016, 10:36 PM

Change 278335 merged by jenkins-bot:
Get a better logger without adapter instance

https://gerrit.wikimedia.org/r/278335

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)).Mar 18 2016, 11:00 PM
gerritbot added a comment.Mar 23 2016, 12:18 AM

Change 279078 had a related patch set uploaded (by Awight):
Tests for new ResultPages functions

https://gerrit.wikimedia.org/r/279078

gerritbot added a comment.Mar 23 2016, 12:21 AM

Change 276218 merged by jenkins-bot:
Enable fail page without adapter instance

https://gerrit.wikimedia.org/r/276218

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)).Mar 23 2016, 7:02 PM
gerritbot added a comment.Mar 24 2016, 6:39 PM

Change 276222 merged by jenkins-bot:
Catch and log errors in adapter constructors

https://gerrit.wikimedia.org/r/276222

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Freshmaking board.Mar 25 2016, 4:35 AM
gerritbot added a comment.Mar 25 2016, 9:22 PM

Change 279078 merged by jenkins-bot:
Tests for new ResultPages functions

https://gerrit.wikimedia.org/r/279078

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Freshmaking board.Mar 29 2016, 11:50 PM
Ejegg closed this task as Resolved.Mar 30 2016, 12:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits