Page MenuHomePhabricator

Catch exceptions in adapter constructor
Closed, ResolvedPublic2 Estimated Story Points

Description

GatewayPage has a top-level exception handler around handleRequest, but nothing around adapter construction, so exceptions there bomb out. We should catch them, log them properly, and show the donors a reasonable fail page.

Event Timeline

Change 276218 had a related patch set uploaded (by Ejegg):
Enable fail page without adapter instance

https://gerrit.wikimedia.org/r/276218

Change 276222 had a related patch set uploaded (by Ejegg):
WIP catch errors in adapter constructors

https://gerrit.wikimedia.org/r/276222

Change 278335 had a related patch set uploaded (by Ejegg):
Get a better logger without adapter instance

https://gerrit.wikimedia.org/r/278335

Change 278335 merged by jenkins-bot:
Get a better logger without adapter instance

https://gerrit.wikimedia.org/r/278335

Change 279078 had a related patch set uploaded (by Awight):
Tests for new ResultPages functions

https://gerrit.wikimedia.org/r/279078

Change 276218 merged by jenkins-bot:
Enable fail page without adapter instance

https://gerrit.wikimedia.org/r/276218

Change 276222 merged by jenkins-bot:
Catch and log errors in adapter constructors

https://gerrit.wikimedia.org/r/276222

Change 279078 merged by jenkins-bot:
Tests for new ResultPages functions

https://gerrit.wikimedia.org/r/279078