Page MenuHomePhabricator

[Bug] Save link does not become active when removing a sitelink
Closed, ResolvedPublic

Description

Reported at https://www.wikidata.org/wiki/Wikidata:Project_chat#Cannot_remove_an_entry and on IRC by Harmonia_Amanda

When you click the icon to remove a sitelink, the row is removed, but the save link does not become active, so the change can't be saved.

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterMake sitelinklistview.tests.js more specific
mediawiki/extensions/Wikibase : wmf/1.27.0-wmf.16Check length of site link list in sitelinklistview::isInitialValue
mediawiki/extensions/Wikibase : masterCheck length of site link list in sitelinklistview::isInitialValue

Event Timeline

Nikki created this task.Mar 10 2016, 10:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2016, 10:00 AM
aude added a subscriber: aude.Mar 10 2016, 12:14 PM

i'm looking at this (though maybe better for Adrian etc. to look)...

in https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/view/resources/jquery/wikibase/toolbar/controller/definitions/edittoolbar/sitelinkgroupview.js#L53

sitelinkgroupview.isInitialValue() is true after i click the trash can, whereas i think it should be false and then trigger enabling the save button

Lydia_Pintscher triaged this task as Unbreak Now! priority.Mar 10 2016, 12:17 PM
aude added a comment.Mar 10 2016, 12:43 PM

git bisect tells me that https://gerrit.wikimedia.org/r/#/c/266727/ is the issue

Change 276448 had a related patch set uploaded (by Aude):
Check length of site link list in sitelinklistview::isInitialValue

https://gerrit.wikimedia.org/r/276448

thiemowmde renamed this task from Save link does not become active when removing a sitelink to [Bug] Save link does not become active when removing a sitelink.Mar 10 2016, 2:18 PM
thiemowmde closed this task as Resolved.
thiemowmde assigned this task to aude.
thiemowmde moved this task from Proposed to Done on the Wikidata-Sprint-2016-03-01 board.

Change 276461 had a related patch set uploaded (by JanZerebecki):
Check length of site link list in sitelinklistview::isInitialValue

https://gerrit.wikimedia.org/r/276461

Change 276448 merged by jenkins-bot:
Check length of site link list in sitelinklistview::isInitialValue

https://gerrit.wikimedia.org/r/276448

Change 276461 merged by jenkins-bot:
Check length of site link list in sitelinklistview::isInitialValue

https://gerrit.wikimedia.org/r/276461

Change 276702 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Make sitelinklistview.tests.js more specific

https://gerrit.wikimedia.org/r/276702

Change 276702 merged by jenkins-bot:
Make sitelinklistview.tests.js more specific

https://gerrit.wikimedia.org/r/276702