Page MenuHomePhabricator
Create Task
Maniphest T129483

A JSON text must at least contain two octets! (JSON::ParserError) in MultimediaViewer, Echo, Flow, RelatedArticles, MobileFrontend and Wikibase browser tests since Aug 2, 2016 12:01 PM
Closed, ResolvedPublic
Actions

Description

Various jobs are seeing mass failures on https://integration.wikimedia.org/ci/view/Selenium/ with the error
A JSON text must at least contain two octets!

...
00:00:09.090 Feature: Multimedia Viewer performance
00:00:09.090 
00:00:09.090   Background:                                                      # features/mmv.performance.feature:4

00:00:11.259     Given I am using a custom user agent                           # features/step_definitions/mmv_performance_steps.rb:26
00:00:11.259     And I am at a wiki article with at least two embedded pictures # features/step_definitions/mmv_steps.rb:3
00:00:11.259       A JSON text must at least contain two octets! (JSON::ParserError)
00:00:11.259       /mnt/home/jenkins-deploy/.gem/2.0.0/gems/json-1.8.3/lib/json/common.rb:155:in `initialize'
...

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Liuxinyu970226 subscribed.May 9 2016, 1:03 AM
zeljkofilipin closed this task as Resolved.May 10 2016, 1:44 PM
zeljkofilipin claimed this task.

Resolved by T128190.

Liuxinyu970226 unsubscribed.May 14 2016, 12:36 AM
phuedx subscribed.EditedAug 3 2016, 11:18 AM

I'm seeing this same error on the MobileFrontend browser tests: https://integration.wikimedia.org/ci/job/selenium-MobileFrontend/103/

The error first started appearing yesterday (Tuesday, 2nd August).

phuedx mentioned this in T141647: [Regression] Fix browser tests for language switching on the beta cluster.Aug 3 2016, 11:19 AM
Tgr subscribed.Aug 3 2016, 5:37 PM

CentralAuth as well.

gerritbot added a comment.Aug 3 2016, 7:01 PM

Change 302766 had a related patch set uploaded (by Dduvall):
Support automatic redirects

https://gerrit.wikimedia.org/r/302766

gerritbot added a comment.Aug 3 2016, 7:06 PM

Change 302766 merged by jenkins-bot:
Support automatic redirects

https://gerrit.wikimedia.org/r/302766

thcipriani reopened this task as Open.Aug 3 2016, 7:40 PM
thcipriani merged a task: T142033: A JSON text must at least contain two octets!.
thcipriani added a subscriber: Jdlrobson.
Jdlrobson renamed this task from A JSON text must at least contain two octets! (JSON::ParserError) in MultimediaViewer browser tests to A JSON text must at least contain two octets! (JSON::ParserError) in MultimediaViewer, RelatedArticles, MobileFrontend and Wikibase browser tests.Aug 3 2016, 7:42 PM
Jdlrobson added a subscriber: thcipriani.

@thcipriani this is somewhat different from the original bug. Tests are passing when run locally and via Jenkins on patch upload but recently have started failing all over the place with this issue. My feeling is there is a common browser test step shared by these extensions that has suddenly started failing or there is an issue with something in the beta cluster infrastructure. I'm a bit lost right now tbh on how to fix this.

Jdlrobson added a project: Reading-Web-Sprint-78-Terminal-Velocity.Aug 3 2016, 7:44 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson renamed this task from A JSON text must at least contain two octets! (JSON::ParserError) in MultimediaViewer, RelatedArticles, MobileFrontend and Wikibase browser tests to A JSON text must at least contain two octets! (JSON::ParserError) in MultimediaViewer, Echo, Flow, RelatedArticles, MobileFrontend and Wikibase browser tests since Aug 2, 2016 12:01 PM.Aug 3 2016, 7:48 PM

Issue seems to have been introduced some time around Aug 2, 2016 12:01 PM.

thcipriani added a subscriber: • dduvall.Aug 3 2016, 7:55 PM

@dduvall and I paired on this a bit. It seems like the faraday gem does not support redirect in some instances from http → https (hence, https://gerrit.wikimedia.org/r/302766).

There are a number of updates that have to happen to get that update in to place. One of which is updating the beta mediawiki_api in environments.yml to use https rather than http, which may fix the symptom of the problem you you're seeing with mobilefrontend @Jdlrobson (https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/tests/browser/environments.yml#L31).

gerritbot added a comment.Aug 3 2016, 7:59 PM

Change 302775 had a related patch set uploaded (by Jdlrobson):
API should use https on the beta cluster

https://gerrit.wikimedia.org/r/302775

Jdlrobson added a comment.EditedAug 3 2016, 8:00 PM

That would make sense. mediawiki_api is defined in integration/config and used by various extensions. Does the above patch make sense as a good starting point?

Thanks @thcipriani and @dduvall for your investigations so far :)

Jdlrobson moved this task from Needs Analysis to Tracking on the Reading-Web-Sprint-78-Terminal-Velocity board.Aug 3 2016, 9:05 PM
dr0ptp4kt moved this task from Incoming to 2014-15 Q4 on the Web-Team-Backlog board.Aug 4 2016, 3:31 PM
gerritbot added a comment.Aug 4 2016, 8:01 PM

Change 302775 merged by jenkins-bot:
API should use https on the beta cluster

https://gerrit.wikimedia.org/r/302775

• dduvall claimed this task.Aug 4 2016, 8:25 PM

In addition to the above integration/config patch, we'll need to update the mediawiki_selenium dependency for each of the following extensions.

  • CentralAuth
  • CentralNotice
  • CirrusSearch
  • Core
  • Echo
  • Flow
  • GettingStarted
  • Math
  • MobileFrontend
  • MultimediaViewer
  • PageTriage
  • QuickSurveys
  • RelatedArticles
  • VisualEditor
  • WikiLove
  • Wikibase
  • Wikidata

Simply edit the Gemfile to specify the newest version (1.7.2) and run bundle install to update the Gemfile.lock. This will pull in the newest version of mediawiki_api which supports automatic redirects.

gerritbot added a comment.Aug 4 2016, 9:03 PM

Change 303007 had a related patch set uploaded (by Jdlrobson):
Upgrade Gemfile

https://gerrit.wikimedia.org/r/303007

gerritbot added a project: Patch-For-Review.Aug 4 2016, 9:03 PM
Jdlrobson created subtask T142141: Upgrade Selenium gem for various reading web opened extensions.Aug 4 2016, 9:05 PM
gerritbot added a comment.Aug 4 2016, 9:11 PM

Change 303007 merged by jenkins-bot:
Upgrade Gemfile

https://gerrit.wikimedia.org/r/303007

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)).Aug 4 2016, 10:00 PM
• dduvall added a comment.Aug 4 2016, 10:18 PM

@Jdlrobson, thanks for taking the initiative on MobileFrontend though your patch doesn't seem to include any changes to Gemfile.lock—the lock file is authoritative when it comes to installing dependencies. Did you run bundle install after bumping the version in Gemfile and before committing?

• dduvall added a comment.Aug 4 2016, 10:29 PM
In T129483#2524381, @dduvall wrote:

@Jdlrobson, thanks for taking the initiative on MobileFrontend though your patch doesn't seem to include any changes to Gemfile.lock—the lock file is authoritative when it comes to installing dependencies. Did you run bundle install after bumping the version in Gemfile and before committing?

See my comments in the subtask about this being a nitpick. The CI jobs should work after bumping the version in Gemfile because the version spec is strict enough to trigger an update. Brain...

gerritbot added a comment.Aug 4 2016, 10:49 PM

Change 303091 had a related patch set uploaded (by Jdlrobson):
Run bundle install

https://gerrit.wikimedia.org/r/303091

phuedx mentioned this in T142141: Upgrade Selenium gem for various reading web opened extensions.Aug 5 2016, 9:29 AM
• dduvall added subscribers: dcausse, SBisson, AndyRussG and 4 others.Aug 8 2016, 5:27 PM

Pinging test maintainers per {T134492: Ownership of Selenium tests} for repositories that have not yet been updated. It would be great to get these updated ASAP. Let me know if you need direction. Also, in addition to updating the gem dependency, please update the beta mediawiki_url in environments.yaml to use 'https` as well. This will avoid the overhead of following redirects.

Repositorycontact
mediawiki/extensions/CentralAuth@Tgr
mediawiki/extensions/CentralNotice@AndyRussG
mediawiki/extensions/CirrusSearch@dcausse
mediawiki/extensions/Echo@SBisson
mediawiki/extensions/Flow@SBisson
mediawiki/extensions/GettingStarted@Mattflaschen-WMF @phuedx
mediawiki/extensions/Math@Physikerwelt
mediawiki/extensions/PageTriage@SBisson
mediawiki/extensions/VisualEditor@Jdforrester-WMF
mediawiki/extensions/WikibaseWikidata @adrianheine
wmde/WikidataBrowserTestsWikidata @adrianheine
mediawiki/extensions/WikiLove@SBisson
gerritbot added a comment.Aug 8 2016, 5:32 PM

Change 303581 had a related patch set uploaded (by Jforrester):
Gemfile: Bump mediawiki_api from 1.7.1 to 1.7.2

https://gerrit.wikimedia.org/r/303581

gerritbot added a comment.Aug 8 2016, 5:44 PM

Change 303584 had a related patch set uploaded (by DCausse):
Update browser test config

https://gerrit.wikimedia.org/r/303584

gerritbot added a comment.Aug 8 2016, 6:33 PM

Change 303584 merged by jenkins-bot:
Update browser test config

https://gerrit.wikimedia.org/r/303584

Tgr added a comment.Aug 8 2016, 9:05 PM

CentralAuth done in https://gerrit.wikimedia.org/r/#/c/303603/

IMO for mechanical tasks like this it would be more efficient for one person to do it, instead of each maintainer having to figure out what to do. A bash script with a few sed and git commands can iterate through all the repos with tests and create changesets.

• Mattflaschen-WMF added a comment.Aug 8 2016, 10:21 PM

Working on Flow and GettingStarted.

gerritbot added a comment.Aug 8 2016, 10:23 PM

Change 303702 had a related patch set uploaded (by Mattflaschen):
Update mediawiki-selenium to 1.7.2 to fix bug

https://gerrit.wikimedia.org/r/303702

gerritbot added a comment.Aug 8 2016, 10:29 PM

Change 303704 had a related patch set uploaded (by Mattflaschen):
Update mediawiki-selenium to 1.7.2 to fix bug

https://gerrit.wikimedia.org/r/303704

gerritbot added a comment.Aug 9 2016, 8:50 AM

Change 303704 merged by jenkins-bot:
Update mediawiki-selenium to 1.7.2 to fix bug

https://gerrit.wikimedia.org/r/303704

adrianheine unsubscribed.Aug 9 2016, 9:12 AM
gerritbot added a comment.Aug 9 2016, 1:24 PM

Change 303702 merged by jenkins-bot:
Update mediawiki-selenium to 1.7.2 to fix bug

https://gerrit.wikimedia.org/r/303702

gerritbot added a comment.Aug 9 2016, 3:48 PM

Change 303581 merged by jenkins-bot:
Gemfile: Bump mediawiki_api from 1.7.1 to 1.7.2

https://gerrit.wikimedia.org/r/303581

gerritbot added a comment.Aug 9 2016, 7:19 PM

Change 303091 merged by jenkins-bot:
Run bundle install

https://gerrit.wikimedia.org/r/303091

Jdlrobson closed subtask T142141: Upgrade Selenium gem for various reading web opened extensions as Resolved.Aug 10 2016, 5:26 PM
Jdlrobson removed a project: Patch-For-Review.Aug 11 2016, 7:19 PM

I think everything is merged? Can we resolve this?

gerritbot added a comment.Aug 11 2016, 7:48 PM

Change 304305 had a related patch set uploaded (by Sbisson):
Browser tests: update to mw-selenium 1.7.2 and https

https://gerrit.wikimedia.org/r/304305

gerritbot added a project: Patch-For-Review.Aug 11 2016, 7:48 PM
gerritbot added a comment.Aug 11 2016, 7:50 PM

Change 304307 had a related patch set uploaded (by Sbisson):
Browser tests: update to mw-selenium 1.7.2 and https

https://gerrit.wikimedia.org/r/304307

gerritbot added a comment.Aug 11 2016, 10:09 PM

Change 304305 merged by jenkins-bot:
Browser tests: update to mw-selenium 1.7.2 and https

https://gerrit.wikimedia.org/r/304305

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)).Aug 11 2016, 11:00 PM
gerritbot added a comment.Aug 12 2016, 4:07 AM

Change 304307 merged by jenkins-bot:
Browser tests: update to mw-selenium 1.7.2 and https

https://gerrit.wikimedia.org/r/304307

gerritbot added a comment.Aug 12 2016, 1:05 PM

Change 304467 had a related patch set uploaded (by Sbisson):
Browser tests: update to mw-selenium 1.7.2 and https

https://gerrit.wikimedia.org/r/304467

gerritbot added a comment.Aug 12 2016, 7:43 PM

Change 304467 merged by jenkins-bot:
Browser tests: update to mw-selenium 1.7.2 and https

https://gerrit.wikimedia.org/r/304467

• Mattflaschen-WMF unsubscribed.Aug 13 2016, 1:18 AM
Jdlrobson removed a project: Patch-For-Review.Aug 15 2016, 7:44 PM
Jdlrobson added subscribers: • Mattflaschen-WMF, greg.

@greg who's responsible for mediawiki/core ? It's the only thing that didn't get patched. If someone can merge my patch I'm about to post I believe this task can be resolved. @Mattflaschen-WMF can you help?

gerritbot added a comment.Aug 15 2016, 7:44 PM

Change 304881 had a related patch set uploaded (by Jdlrobson):
Browser tests: update to mw-selenium 1.7.2 and https

https://gerrit.wikimedia.org/r/304881

gerritbot added a project: Patch-For-Review.Aug 15 2016, 7:44 PM
Jdlrobson added a project: Reading-Web-Sprint-79-Uh-oh.Aug 15 2016, 7:44 PM
Jdlrobson moved this task from Needs Analysis to Tracking on the Reading-Web-Sprint-79-Uh-oh board.
greg added a comment.Aug 15 2016, 9:32 PM
In T129483#2554816, @Jdlrobson wrote:

@greg who's responsible for mediawiki/core ? It's the only thing that didn't get patched. If someone can merge my patch I'm about to post I believe this task can be resolved. @Mattflaschen-WMF can you help?

For now, @zeljkofilipin / RelEng

zeljkofilipin added a project: User-zeljkofilipin.Aug 16 2016, 10:42 AM
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
Jdlrobson added a comment.Aug 16 2016, 11:12 PM

@zeljkofilipin I've added you to the patch for review so we can try to get the core browser tests green again.

• Mattflaschen-WMF added a comment.Aug 17 2016, 12:13 AM

I +2'ed core. I agree with Tgr though:

In T129483#2534980, @Tgr wrote:

IMO for mechanical tasks like this it would be more efficient for one person to do it, instead of each maintainer having to figure out what to do. A bash script with a few sed and git commands can iterate through all the repos with tests and create changesets.

This is often done (though I don't know how automatically) for browser test changes already.

gerritbot added a comment.Aug 17 2016, 12:19 AM

Change 304881 merged by jenkins-bot:
Browser tests: update to mw-selenium 1.7.2 and https

https://gerrit.wikimedia.org/r/304881

zeljkofilipin added a comment.Aug 17 2016, 3:02 PM

I have just took a look at all selenium-* jobs and the only one still failing with JSON::ParserError is selenium-Wikidata.

Jdlrobson closed this task as Resolved.EditedAug 17 2016, 3:14 PM

This is fixed. Remaining browser test issues are covered in T142600 Various tests failing due to login .

Jdlrobson reopened this task as Open.Aug 17 2016, 3:14 PM

My bad yes there is that one still.

Jdlrobson added a subscriber: daniel.Aug 17 2016, 3:15 PM
gerritbot added a comment.Aug 17 2016, 3:27 PM

Change 305271 had a related patch set uploaded (by Zfilipin):
WIP Fix JSON::ParserError

https://gerrit.wikimedia.org/r/305271

zeljkofilipin added a comment.Aug 17 2016, 3:29 PM

I have tried updating wikidata/browsertests repository (305271) but got this:

$ bundle
Fetching gem metadata from https://rubygems.org/..........
Fetching version metadata from https://rubygems.org/...
Fetching dependency metadata from https://rubygems.org/..
Resolving dependencies...
Bundler could not find compatible versions for gem "mediawiki_api":
  In Gemfile:
    mediawiki_selenium (>= 1.7.2, ~> 1.7) ruby depends on
      mediawiki_api (>= 0.7.0, ~> 0.7) ruby

    mediawiki_api-wikidata (>= 0.2.1, ~> 0.2.0) ruby depends on
      mediawiki_api (0.6.0)
zeljkofilipin closed this task as Resolved.Aug 17 2016, 3:43 PM

The last one is resolved in 305271.

gerritbot added a comment.Aug 17 2016, 3:56 PM

Change 305271 merged by jenkins-bot:
Fix JSON::ParserError

https://gerrit.wikimedia.org/r/305271

thiemowmde mentioned this in R1909:c507484ef42d: Fix JSON::ParserError.Aug 17 2016, 4:47 PM
zeljkofilipin mentioned this in R1909:ec1e6539d4e6: WIP Fix JSON::ParserError.Aug 17 2016, 4:47 PM
zeljkofilipin mentioned this in R1909:35dce15cf8ca: WIP Fix JSON::ParserError.
ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)).Aug 18 2016, 3:01 PM
• Phabricator_maintenance moved this task from 2014-15 Q4 to 2016-17 Q1 on the Web-Team-Backlog board.Mar 6 2018, 11:50 PM
Restricted Application edited projects, added Multimedia; removed MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)), MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)). · View Herald TranscriptMar 6 2018, 11:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL