Page MenuHomePhabricator
Create Task
Maniphest T129522

Crash in image protocol
Closed, ResolvedPublic
Actions

Description

https://rink.hockeyapp.net/manage/apps/152731/app_versions/40/crash_reasons/113809573

Not sure of repro steps.

But the crash is caused because self is nil - we need to bail if self has been deallocated

Related Objects

Event Timeline

• Fjalapeno created this task.Mar 10 2016, 6:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2016, 6:05 PM
• Fjalapeno added a project: iOS-app-v5.0.1-Kiwi.Mar 10 2016, 6:05 PM
• Fjalapeno moved this task from Tasks from Product Backlog to Doing on the iOS-app-v5.0.1-Kiwi board.
• Fjalapeno moved this task from Doing to Needs Code Review on the iOS-app-v5.0.1-Kiwi board.Mar 10 2016, 6:53 PM
Diffusion mentioned this in rAPIOS4ac259ce58a3: Merge pull request #596 from wikimedia/feature/image-protocol-crash/T129522.Mar 10 2016, 7:41 PM
Mhurd moved this task from Needs Code Review to Needs QA on the iOS-app-v5.0.1-Kiwi board.Mar 10 2016, 7:41 PM
• Fjalapeno moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.0.1-Kiwi board.Mar 10 2016, 10:56 PM
Nicholas.tsg subscribed.Mar 10 2016, 11:00 PM

As requested by Mhurd I moved to the Blocked or Waiting section.

• JMinor closed this task as Resolved.Mar 11 2016, 9:34 PM
• Fjalapeno reopened this task as Open.Mar 22 2016, 7:50 PM
• Fjalapeno edited projects, added iOS-app-v5.0.2-Rubiks; removed iOS-app-v5.0.1-Kiwi.
• Fjalapeno moved this task from Tasks from Product Backlog to Design Doing on the iOS-app-v5.0.2-Rubiks board.
• Fjalapeno moved this task from Design Doing to Ready for Development on the iOS-app-v5.0.2-Rubiks board.

Still getting this crash…

https://rink.hockeyapp.net/manage/apps/152731/app_versions/42/crash_reasons/115370679

• JMinor triaged this task as Medium priority.Mar 22 2016, 9:43 PM
• Fjalapeno moved this task from Ready for Development to Doing on the iOS-app-v5.0.2-Rubiks board.Mar 23 2016, 5:15 PM
• Fjalapeno added a comment.Mar 23 2016, 7:16 PM

Possible clue:

https://forums.developer.apple.com/thread/26081

• Fjalapeno added a comment.Mar 23 2016, 7:17 PM

Another:
https://forums.developer.apple.com/thread/24923

• Fjalapeno moved this task from Doing to Needs Code Review on the iOS-app-v5.0.2-Rubiks board.Mar 24 2016, 4:00 PM
• Fjalapeno mentioned this in rAPIOSf39fb5456b06: Merge branch 'develop' into feature/image-proto-fix/T129522.Mar 24 2016, 4:08 PM
• Fjalapeno mentioned this in rAPIOSee74540e65f7: Merge branch 'develop' into feature/image-proto-fix/T129522.Mar 24 2016, 5:26 PM
• Fjalapeno mentioned this in rAPIOS1118245c102a: Merge branch 'develop' into feature/image-proto-fix/T129522.Mar 25 2016, 4:32 PM
• Fjalapeno mentioned this in rAPIOS49b6305cf22f: Merge branch 'develop' into feature/image-proto-fix/T129522.Mar 25 2016, 6:59 PM
Diffusion mentioned this in rAPIOSa9b4c559205e: Merge pull request #620 from wikimedia/feature/image-proto-fix/T129522.Mar 25 2016, 10:32 PM
Mhurd moved this task from Needs Code Review to Needs QA on the iOS-app-v5.0.2-Rubiks board.Mar 25 2016, 10:34 PM
Nicholas.tsg added a comment.Mar 27 2016, 8:18 PM

I checked on iOS 9 with the latest build 5.0.2 (797), haven't noticed any issues. I'll leave this in Needs QA until testing on an iOS 8 device on Tuesday.

• Fjalapeno moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.0.2-Rubiks board.Mar 29 2016, 6:08 PM
• Fjalapeno added a comment.Mar 30 2016, 6:12 PM

dea8ab7b402185874778d1570319d9b0.log87 KBDownload

Adding crash log

• Fjalapeno moved this task from Ready for PM Signoff to Blocked or Waiting on the iOS-app-v5.0.2-Rubiks board.Mar 30 2016, 6:14 PM
• Fjalapeno moved this task from Blocked or Waiting to Ready for Development on the iOS-app-v5.0.2-Rubiks board.

Still not fixed with the latest changes… back to the drawing board.

• JMinor added a project: iOS-app-v5.0.3-Disco.Mar 30 2016, 10:44 PM
• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v5.0.3-Disco board.Mar 30 2016, 11:05 PM
• Fjalapeno added a subscriber: Mhurd.Mar 31 2016, 5:30 PM

@Mhurd looking at a few potential fixes and also exploring getting rid of the protocol and using a cache strategy

• Fjalapeno moved this task from Ready for Development to Needs Testing Criteria on the iOS-app-v5.0.3-Disco board.Apr 8 2016, 2:33 PM

Possibly fixed in this pr:

https://github.com/wikimedia/wikipedia-ios/pull/648

No way to test, until we release.

Moving to PM signoff

• Fjalapeno added a comment.Apr 8 2016, 2:35 PM

https://rink.hockeyapp.net/manage/apps/152731/app_versions/45/crash_reasons/116163933

• Fjalapeno moved this task from Needs Testing Criteria to Ready for PM Signoff on the iOS-app-v5.0.3-Disco board.Apr 8 2016, 2:35 PM
• JMinor closed this task as Resolved.Apr 21 2016, 9:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL