|mediawiki/extensions/CharInsert : wmf/1.27.0-wmf.16||Revert "Remove inline event handler js from charinsert"|
|mediawiki/extensions/CharInsert : master||Revert "Remove inline event handler js from charinsert"|
- Mentioned In
T88922: ReferenceError due to CharInsert extension not loading mediawiki.toolbar before it is used
T92781: EditTools issues on Special:Upload
- Mentioned Here
- T88922: ReferenceError due to CharInsert extension not loading mediawiki.toolbar before it is used
rECHIb2f7c4c507e5: Remove inline event handler js from charinsert
T129667: Inserting characters from MediaWiki:Edittools broken
https://nl.wikipedia.org/wiki/MediaWiki:Onlyifediting.js changes the edit tools a bit, didn't look at the default on-Gadgets.
If we can't identify the cause, I'd rather revert than leave it broken over the weekend...
btw, I finally got around to debugging this.
Cause appears to be setting the innerHTML of the element containing charinsert tags. This caused those elements to loose their event handlers (At least in firefox). It didn't matter in the old version, since the event handlers were inline.
I'll work on trying to update those gadgets.
For reference, a modified version of the gadget at nlwiki is at https://nl.wikipedia.org/wiki/Gebruiker:Bawolff/sandbox.js
It appears that some wikis have some more modern versions of the gadget, which might not exhibit the same problem
Ok, so we're going to try this change again: https://gerrit.wikimedia.org/r/#/c/288922/
However, before that I'm hoping to get the scripts that I know will break fixed.
Wikis that have been fixed
(If anyone is aware of any other wikis that broke last time around, please let me know)