Page MenuHomePhabricator

Security review of Romanian diacritics rendering reader assessment gadget
Closed, InvalidPublic

Event Timeline

Yes, most likely in May. I plan to have the code deployed in early June. However, it was suggested that I might use eventlogging, which would significantly reduce the quantity of code (no more server-side code).

@Jdforrester-WMF is this at the point where you want a review now?

@Jdforrester-WMF is this at the point where you want a review now?

I spoke with @Strainu at the Hackathon and I believe they were exploring using server-side PHP language re-writes instead of this tactic, in which case this can be closed as Invalid – Strainu?

I'm still exploring the usage of EventLogging for this. Please give me another week to come up with a final answer.

Thanks for the update. I've tentatively rescheduled for the week of May 30th. Let me know if it looks like it won't be ready by then.

Also, happy to review the overall design now, if you have that written up anywhere?

We'll be using EventLogging for this feature after all. Is a security review still needed?

We'll be using EventLogging for this feature after all. Is a security review still needed?

If the only thing you're adding is EventLogging to track, no review needed. If you're pushing out the EventLogging change as a new extension, then I would want to just quickly take a look.

Strainu added a subscriber: Milimetric.

No new extension, only calls to EventLogging. @Milimetric will hopefully review the code anyway, just to make sure we can get the info required.

James was making a confusion with T131585 I believe, which is still a long way off (if the poll results shows it's needed at all). Closing the bug as invalid, thanks all for your help.