Page MenuHomePhabricator
Create Task
Maniphest T129615

Remove references to external images that are actually 404s
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Seems that we did something quickly for the A/B test, and didn't clean/improve the code before pushing to production.

We need to fix these lines:
https://github.com/wikimedia/portals/blob/af01e3bf5850317b60ee6e1ec55125a767acc373/dev/wikipedia.org/assets/postcss/_pab2.css#L53-L58

Thankfully most browsers are not impacted by this bug, because they will read the data URI first.
See support for Data URIs: http://caniuse.com/#feat=datauri

Details

ProjectBranchLines +/-Subject
wikimedia/portalsmaster+18 -12Replacing typeahead placeholder images with local versions.
Customize query in gerrit

Related Objects
Search...

Event Timeline

JGirault created this task.Mar 11 2016, 2:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2016, 2:13 AM
Jdrewniak claimed this task.Mar 11 2016, 4:48 PM
debt triaged this task as Medium priority.Mar 14 2016, 6:11 PM
debt moved this task from Backlog to What's Next on the Discovery-Portal-Sprint board.
Deskana moved this task from Needs triage to On Sprint Board on the Discovery board.Mar 14 2016, 8:30 PM
Jdrewniak set the point value for this task to 1.Mar 15 2016, 12:35 PM
Krinkle added a project: Wikimedia-Portals.Mar 23 2016, 8:05 PM
gerritbot added a subscriber: gerritbot.Apr 13 2016, 2:13 PM

Change 283187 had a related patch set uploaded (by Jdrewniak):
Replacing typeahead placeholder images with local versions.

https://gerrit.wikimedia.org/r/283187

gerritbot added a project: Patch-For-Review.Apr 13 2016, 2:13 PM
Jdrewniak moved this task from What's Next to Needs code review on the Discovery-Portal-Sprint board.Apr 13 2016, 2:13 PM
JGirault added a comment.Apr 14 2016, 6:25 PM

@Jdrewniak I merged, but it would be nice to add a cache buster to these images.

gerritbot added a comment.Apr 14 2016, 6:32 PM

Change 283187 merged by jenkins-bot:
Replacing typeahead placeholder images with local versions.

https://gerrit.wikimedia.org/r/283187

Jdrewniak moved this task from Needs code review to Done on the Discovery-Portal-Sprint board.Apr 14 2016, 6:46 PM
debt closed this task as Resolved.Apr 14 2016, 7:43 PM
debt added a parent task: T130755: [EPIC] Portal Production release: bug fixes and small updates.
debt added a subscriber: debt.

This will go out in this production release: https://phabricator.wikimedia.org/T130755

debt moved this task from Done to Completed on the Discovery-Portal-Sprint board.Apr 14 2016, 11:26 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL