Page MenuHomePhabricator
Create Task
Maniphest T129619

Keyboard users: Tabbing through new Portal input has no visual feedback on language switcher
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

When tabbing through new Portal input field, the language switcher does get focus and is useable by letter input or arrow keys, but there is no visual difference between focus and normal state.

Details

ProjectBranchLines +/-Subject
wikimedia/portalsmaster+34 -4Adding 'focus' feedback to language picker.
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Mar 11 2016, 2:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2016, 2:50 AM
debt added a subscriber: debt.Mar 11 2016, 3:42 AM

Hi - can you add in the browser/OS version you saw this in, please?

debt added a project: Discovery.Mar 11 2016, 3:42 AM
Volker_E added a comment.Mar 11 2016, 7:04 AM

@debt It's independent from browser, it's an input issue. But for the sake of completeness, first seen in Chrome 49/Mac.

debt triaged this task as Medium priority.Mar 11 2016, 4:43 PM
debt moved this task from Backlog to What's Next on the Discovery-Portal-Sprint board.
Deskana moved this task from Needs triage to On Sprint Board on the Discovery board.Mar 14 2016, 8:30 PM
Jdrewniak claimed this task.Mar 15 2016, 12:35 PM
Jdrewniak set the point value for this task to 5.
Krinkle added a project: Wikimedia-Portals.Mar 23 2016, 8:05 PM
Jdrewniak moved this task from What's Next to In Progress on the Discovery-Portal-Sprint board.Apr 12 2016, 1:31 PM
gerritbot added a subscriber: gerritbot.Apr 12 2016, 1:34 PM

Change 282921 had a related patch set uploaded (by Jdrewniak):
Adding 'focus' feedback to language picker.

https://gerrit.wikimedia.org/r/282921

gerritbot added a project: Patch-For-Review.Apr 12 2016, 1:34 PM
Jdrewniak moved this task from In Progress to Needs code review on the Discovery-Portal-Sprint board.Apr 12 2016, 1:35 PM
gerritbot added a comment.Apr 13 2016, 4:54 PM

Change 282921 merged by jenkins-bot:
Adding 'focus' feedback to language picker.

https://gerrit.wikimedia.org/r/282921

Jdrewniak moved this task from Needs code review to Done on the Discovery-Portal-Sprint board.Apr 14 2016, 4:47 PM
debt closed this task as Resolved.Apr 14 2016, 6:11 PM

Looks good on http://www.wikipedia.beta.wmflabs.org/ and will be part of this production release: https://phabricator.wikimedia.org/T130755

Screen Shot 2016-04-14 at 12.09.40 PM.png (133×266 px, 5 KB)

debt added a parent task: T130755: [EPIC] Portal Production release: bug fixes and small updates.Apr 14 2016, 6:11 PM
debt moved this task from Done to Completed on the Discovery-Portal-Sprint board.Apr 14 2016, 11:25 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL