Page MenuHomePhabricator
Create Task
Maniphest T129650

Auto-filled external link field should remain selected when switching from internal link option
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

  1. Write "apple"
  2. Try to add an external link to this word
  3. Just paste your link into the external link field
  4. Observe that your newly created link is a mess, because the word "apple" was showing up as a suggestion in the field, and you were supposed to remove it before pasting the link.

This passage feels totally unnecessary, counterintuitive and cumbersome even for cases where the URL is typed rather than pasted.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+6 -2MWLinkAnnotationInspector: select entire link when switching tabs
Customize query in gerrit

Event Timeline

Elitre created this task.Mar 11 2016, 1:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2016, 1:54 PM
Elitre updated the task description. (Show Details)Mar 11 2016, 2:03 PM
Elitre updated the task description. (Show Details)
Esanders added a subscriber: Esanders.Mar 11 2016, 4:00 PM

If I open the link inspector, apple is a suggestion but it also selected, so pressing paste overwrites it - leaving a clean link.

Elitre added a comment.Mar 11 2016, 4:09 PM

It's selected in the Search pages (internal wikilink) tab, not in the External link one.

Jdforrester-WMF renamed this task from External link field must be empty when adding link to existing word to Auto-filled external link field should remain selected when switching from internal link option.Mar 15 2016, 7:21 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF edited projects, added VisualEditor-MediaWiki-Links; removed VisualEditor-Links.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
gerritbot added a subscriber: gerritbot.Mar 28 2016, 4:39 PM

Change 279961 had a related patch set uploaded (by DLynch):
MWLinkAnnotationInspector: select entire link when switching tabs

https://gerrit.wikimedia.org/r/279961

gerritbot added a project: Patch-For-Review.Mar 28 2016, 4:39 PM
Jdforrester-WMF closed this task as Resolved.Mar 28 2016, 7:13 PM
Jdforrester-WMF assigned this task to DLynch.
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Mar 28 2016, 7:22 PM

Change 279961 merged by jenkins-bot:
MWLinkAnnotationInspector: select entire link when switching tabs

https://gerrit.wikimedia.org/r/279961

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)).Mar 28 2016, 8:01 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL