Migrate to WKWebkit and new JS interface to improve stability of article display
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Fjalapeno
	Mar 11 2016, 5:33 PM

Description

https://rink.hockeyapp.net/manage/apps/152731/app_versions/40/crash_reasons/114034909

We are crashing when trying to update the js context during a size transition. This is likely either when the web view is coming onscreen, or during rotation.

The crash is in the JSCore (javascript) framework.

My guess is that It happens more on iPad because people rotate devices more on an iPad than iPhone

Since JSCore is a blackbox, my first suggestion is to replace UiWebview with WKWebview - switching to the modern API has a chance of fixing the issue - even if it doesn't, we don't want to go into a deep dive debugging on a legacy API

Related Objects

Mentioned In: rAPIOSd99f5a8de911: Merge pull request #606 from wikimedia/feature/web-crash/T129661

Event Timeline

• Fjalapeno created this task.Mar 11 2016, 5:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2016, 5:33 PM

• Fjalapeno claimed this task.Mar 11 2016, 5:33 PM

• Fjalapeno moved this task from Doing to Needs Code Review on the iOS-app-v5.0.1-Kiwi board.Mar 11 2016, 5:41 PM

• Fjalapeno moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Mar 11 2016, 5:55 PM

Diffusion mentioned this in rAPIOSd99f5a8de911: Merge pull request #606 from wikimedia/feature/web-crash/T129661.Mar 11 2016, 6:13 PM

Mhurd moved this task from Needs Code Review to Needs QA on the iOS-app-v5.0.1-Kiwi board.Mar 11 2016, 7:18 PM

• Fjalapeno moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.0.1-Kiwi board.Mar 11 2016, 8:44 PM

• JMinor closed this task as Resolved.Mar 11 2016, 9:34 PM

• Fjalapeno reopened this task as Open.Mar 24 2016, 8:05 PM

• Fjalapeno edited projects, added iOS-app-v5.0.2-Rubiks; removed iOS-app-v5.0.1-Kiwi.

• Fjalapeno moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v5.0.2-Rubiks board.

• Fjalapeno moved this task from Ready for Development to Blocked or Waiting on the iOS-app-v5.0.2-Rubiks board.

• Fjalapeno moved this task from Blocked or Waiting to Doing on the iOS-app-v5.0.2-Rubiks board.Mar 25 2016, 1:11 PM

• Fjalapeno moved this task from Doing to Blocked or Waiting on the iOS-app-v5.0.2-Rubiks board.Mar 28 2016, 5:07 PM

This issues doesn't have a straight forward solution. Its an issue with Javascript Core in the UIWebView.

At this point the options are:

Start doing a lot of low level debugging of the UIWebView with instruments.
Since UIWebView is deprecated technology, just migrate to WKWebView and then re-assess.

I'm leaning towards 2 right now, as I ant justify dumping an unknown mount of time in debugging a component that we plan on dropping very soon. And since WKWebView is more modern, if we get really lucky it may just fix the issue, and if not, since its much more customizable, we will probably be able to fix it easier.

Either way, pushing this ticket back right now because both options will take a little bit of time and I want to get to some higher priority stuff over the next few days.

• Fjalapeno triaged this task as Medium priority.Mar 28 2016, 5:22 PM

• Fjalapeno moved this task from Blocked or Waiting to Ready for Development on the iOS-app-v5.0.2-Rubiks board.

For reference, this bug is responsible for 20% of our crashes. This is the largest single source of crashes that we have yet to fix.

Note: We have a fix for a bigger crasher (about 35%) waiting for our next deployment.

• JMinor added projects: iOS-app-Bugs, iOS-app-v5.0.3-Disco.Mar 30 2016, 10:45 PM

• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v5.0.3-Disco board.Mar 30 2016, 11:05 PM

• JMinor removed a project: iOS-app-v5.0.3-Disco.Apr 11 2016, 7:29 PM

• JMinor added a project: iOS-app-v5.1.0-Saturn.May 9 2016, 11:28 PM

@JMinor this is the "unknown crash" in iTunes. We can discus whether we want to release this with the other framework bug fix in a 5.0.5 release

• Fjalapeno updated the task description. (Show Details)May 10 2016, 3:58 PM

• Fjalapeno moved this task from Blocked or Waiting to Ready for Development on the iOS-app-v5.1.0-Saturn board.May 12 2016, 1:38 PM

• Fjalapeno moved this task from Ready for Development to Doing on the iOS-app-v5.1.0-Saturn board.May 12 2016, 7:34 PM

• JMinor renamed this task from Web view controller crash during rotation (probably) from Hockey to Migrate to WKWebkit and new JS interface to improve stability of article display.May 13 2016, 6:56 PM

• JMinor raised the priority of this task from Medium to High.

• JMinor added a project: iOS-app-v5.0.5-Fever.

• JMinor moved this task from Tasks from Product Backlog to Doing on the iOS-app-v5.0.5-Fever board.May 13 2016, 8:19 PM

• JMinor removed projects: iOS-app-v5.1.0-Saturn, iOS-app-v5.0.2-Rubiks.May 13 2016, 8:28 PM

• JMinor reassigned this task from • Fjalapeno to Mhurd.May 19 2016, 4:31 PM

• Fjalapeno moved this task from Doing to Needs Testing Criteria on the iOS-app-v5.0.5-Fever board.Jun 15 2016, 8:11 PM

• Fjalapeno moved this task from Needs Testing Criteria to Ready for PM Signoff on the iOS-app-v5.0.5-Fever board.