Page MenuHomePhabricator
Create Task
Maniphest T129696

Multi-line title or description causes visual overflow
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

At https://www.wikipedia.org/ - clicking on a link makes multi-line title or description be a single-line, thus overflowing the suggestions box.

Easily testable with "monkey" (for description) or "Montréal–Pierre Elliott Trudeau International Airport" (for title)

Ogg screencast video at F3617920 (click "View file" to watch or download it)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fixes visual overflow when clicking on a suggestion link. Also makes whole suggestion link clickable.wikimedia/portalsmaster+42 -18
Customize query in gerrit

Related Objects
Search...

Event Timeline

Quiddity created this task.Mar 11 2016, 9:04 PM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptMar 11 2016, 9:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Quiddity updated the task description. (Show Details)Mar 11 2016, 9:07 PM
• debt triaged this task as Medium priority.Mar 12 2016, 12:52 AM
• debt moved this task from Backlog to What's Next on the Discovery-Portal-Sprint board.
• debt added subscribers: • JGirault, Jdrewniak, • MSyed.
• debt added subscribers: abian, • debt.EditedMar 12 2016, 3:13 PM

Updating this ticket with a screenshot from @abian:

Jdrewniak claimed this task.Mar 14 2016, 2:14 PM
Jdrewniak set the point value for this task to 3.
Jdrewniak moved this task from What's Next to In Progress on the Discovery-Portal-Sprint board.Mar 14 2016, 2:19 PM
• Deskana moved this task from Needs triage to On Sprint Board on the Discovery-ARCHIVED board.Mar 14 2016, 8:30 PM
Krinkle moved this task from Untriaged to Bugs on the Wikimedia-Portals board.Mar 17 2016, 12:49 AM
gerritbot subscribed.Mar 22 2016, 8:19 PM

Change 278972 had a related patch set uploaded (by Jdrewniak):
Fixes visual overflow when clicking on a suggestion link. Also makes whole suggestion link clickable.

https://gerrit.wikimedia.org/r/278972

gerritbot added a project: Patch-For-Review.Mar 22 2016, 8:19 PM
Jdrewniak moved this task from In Progress to Needs code review on the Discovery-Portal-Sprint board.Mar 22 2016, 8:19 PM
Jdrewniak moved this task from Needs code review to Done on the Discovery-Portal-Sprint board.Mar 23 2016, 1:39 PM
• debt added a parent task: T130755: [EPIC] Portal Production release: bug fixes and small updates.Mar 23 2016, 6:42 PM
• debt closed this task as Resolved.Mar 23 2016, 6:45 PM

Resolving this ticket - will go into production with this: https://phabricator.wikimedia.org/T130755

gerritbot added a comment.Mar 24 2016, 6:44 PM

Change 278972 merged by jenkins-bot:
Fixes visual overflow when clicking on a suggestion link. Also makes whole suggestion link clickable.

https://gerrit.wikimedia.org/r/278972

• debt moved this task from Done to Completed on the Discovery-Portal-Sprint board.Apr 7 2016, 3:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits