Page MenuHomePhabricator

Echo: Call to a member function getLocalURL() on a non-object (null) in EditThresholdPresentationModel.php
Closed, DuplicatePublic

Description

Spotted in production:

1[
2 {
3 "file":"/srv/mediawiki/php-1.27.0-wmf.16/extensions/Echo/includes/formatters/SpecialNotificationsFormatter.php",
4 "line":41,
5 "function":"getPrimaryLink",
6 "class":"EchoEditThresholdPresentationModel",
7 "type":"->",
8 "args":[
9
10 ]
11 },
12 {
13 "file":"/srv/mediawiki/php-1.27.0-wmf.16/extensions/Echo/includes/formatters/EchoEventFormatter.php",
14 "line":30,
15 "function":"formatModel",
16 "class":"SpecialNotificationsFormatter",
17 "type":"->",
18 "args":[
19 "EchoEditThresholdPresentationModel"
20 ]
21 },
22 {
23 "file":"/srv/mediawiki/php-1.27.0-wmf.16/extensions/Echo/includes/DataOutputFormatter.php",
24 "line":142,
25 "function":"format",
26 "class":"EchoEventFormatter",
27 "type":"->",
28 "args":[
29 "EchoEvent"
30 ]
31 },
32 {
33 "file":"/srv/mediawiki/php-1.27.0-wmf.16/extensions/Echo/includes/DataOutputFormatter.php",
34 "line":117,
35 "function":"formatNotification",
36 "class":"EchoDataOutputFormatter",
37 "type":"::",
38 "args":[
39 "EchoEvent",
40 "User",
41 "string",
42 "LanguageJa"
43 ]
44 },
45 {
46 "file":"/srv/mediawiki/php-1.27.0-wmf.16/extensions/Echo/includes/special/SpecialNotifications.php",
47 "line":54,
48 "function":"formatOutput",
49 "class":"EchoDataOutputFormatter",
50 "type":"::",
51 "args":[
52 "EchoNotification",
53 "string",
54 "User",
55 "LanguageJa"
56 ]
57 },
58 {
59 "file":"/srv/mediawiki/php-1.27.0-wmf.16/includes/specialpage/SpecialPage.php",
60 "line":407,
61 "function":"execute",
62 "class":"SpecialNotifications",
63 "type":"->",
64 "args":[
65 "NULL"
66 ]
67 },
68 {
69 "file":"/srv/mediawiki/php-1.27.0-wmf.16/includes/specialpage/SpecialPageFactory.php",
70 "line":565,
71 "function":"run",
72 "class":"SpecialPage",
73 "type":"->",
74 "args":[
75 "NULL"
76 ]
77 },
78 {
79 "file":"/srv/mediawiki/php-1.27.0-wmf.16/includes/MediaWiki.php",
80 "line":282,
81 "function":"executePath",
82 "class":"SpecialPageFactory",
83 "type":"::",
84 "args":[
85 "Title",
86 "RequestContext"
87 ]
88 },
89 {
90 "file":"/srv/mediawiki/php-1.27.0-wmf.16/includes/MediaWiki.php",
91 "line":738,
92 "function":"performRequest",
93 "class":"MediaWiki",
94 "type":"->",
95 "args":[
96
97 ]
98 },
99 {
100 "file":"/srv/mediawiki/php-1.27.0-wmf.16/includes/MediaWiki.php",
101 "line":519,
102 "function":"main",
103 "class":"MediaWiki",
104 "type":"->",
105 "args":[
106
107 ]
108 },
109 {
110 "file":"/srv/mediawiki/php-1.27.0-wmf.16/index.php",
111 "line":43,
112 "function":"run",
113 "class":"MediaWiki",
114 "type":"->",
115 "args":[
116
117 ]
118 },
119 {
120 "file":"/srv/mediawiki/w/index.php",
121 "line":3,
122 "function":"include",
123 "args":[
124 "string"
125 ]
126 }
127]

Related Objects

Event Timeline

demon created this task.Mar 11 2016, 11:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

We already noticed this separately and fixed it in https://gerrit.wikimedia.org/r/#/c/276788/ . We should probably cherry-pick that and SWAT it on Monday, I'll take care of that.

Change 276916 had a related patch set uploaded (by Catrope):
thank-you-edit: canRender for deleted page and extra fix

https://gerrit.wikimedia.org/r/276916

demon reopened this task as Open.Mar 12 2016, 12:01 AM
demon triaged this task as Normal priority.

Change 276916 merged by jenkins-bot:
thank-you-edit: canRender for deleted page and extra fix

https://gerrit.wikimedia.org/r/276916