Page MenuHomePhabricator

Table sort icons inverted
Closed, ResolvedPublic

Description

@MatthiasDD on rMW9080b6f763a08fe39c3dd854e8555d1748625fca

You have changed the content of the files "core\resources\src\jquery\images\sort_down.*" and "...sort_up.*". The sort_down.gif was former a triangle upwards! This symbol show the actual sort state (upwards) and after click table sorts down.
Please change the filenames.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2016, 12:15 PM

Having a file/class named 'down' which shows an up arrow was clearly a bad idea. I'll fix this by switching the class order.

Change 277071 had a related patch set uploaded (by Esanders):
Follow-up Ia16e19985: Fix table sort arrow direction

https://gerrit.wikimedia.org/r/277071

Change 277071 merged by jenkins-bot:
Follow-up Ia16e19985: Fix table sort arrow direction

https://gerrit.wikimedia.org/r/277071

matmarex closed this task as Resolved.Mar 14 2016, 2:25 PM
matmarex removed a project: Patch-For-Review.