Page MenuHomePhabricator

[Regression pre-wmf.17] OOjs doesn't load in debug mode (and thus OOUI, interface components, VisualEditor, Flow, …)
Closed, ResolvedPublic0 Story Points

Event Timeline

Esanders raised the priority of this task from High to Unbreak Now!.Mar 14 2016, 3:53 PM

This is preventing the whole VE team from effectively doing their job.

Also moment.js is similarly broken.

That seems most unlikely. More likely it was caused by https://gerrit.wikimedia.org/r/#/c/260071/ (which we already knew broke debug mode for modules using module.exports) - and was fixed three days ago by aforementioned https://gerrit.wikimedia.org/r/#/c/271921/

Change 277289 had a related patch set uploaded (by Krinkle):
resourceloader: Add back-compat globals for requirable modules

https://gerrit.wikimedia.org/r/277289

Krinkle claimed this task.Mar 14 2016, 5:53 PM
Krinkle moved this task from Inbox to Assigned on the MediaWiki-ResourceLoader board.
Krinkle removed subscribers: phuedx, Jhernandez, Catrope and 11 others.

Change 277289 merged by jenkins-bot:
resourceloader: Remove 'require' and 'module' from debug mode

https://gerrit.wikimedia.org/r/277289

Jdforrester-WMF closed this task as Resolved.Mar 14 2016, 6:44 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 0.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJul 13 2016, 4:00 PM