Page MenuHomePhabricator

Modals need an x close button, or click outside the box to close
Closed, DuplicatePublic

Description

When you open a window to assign a article, there is no "x" button to close the window. You can only close it by clicking on the purple button again, which is not immediately obvious. This is also true for assign a review, and any of the modals that open with a + icon.

There should be an x at the top right corner of modals.

You should also be able to close the modal by clicking outside of the box.


Event Timeline

Restricted Application added subscribers: Base, Aklapper. · View Herald TranscriptMar 13 2016, 10:32 PM
DannyH moved this task from New & TBD Tickets to Programs + User groups on the Community-Tech board.
DannyH added a subscriber: DannyH.
DannyH renamed this task from There should be a "x" button in the article assignment window to Article assignment window needs an x close button, or click outside the box to close.Jul 11 2016, 11:34 PM
DannyH updated the task description. (Show Details)

This is essentially the same issue as https://github.com/WikiEducationFoundation/WikiEduDashboard/issues/648

We want all the popovers like this to close with a click outside, but it may require some significant refactoring of how we handle the open/closed state of these modals.

DannyH renamed this task from Article assignment window needs an x close button, or click outside the box to close to Modals need an x close button, or click outside the box to close.Sep 21 2016, 9:39 PM
DannyH updated the task description. (Show Details)Sep 21 2016, 9:42 PM