(copied from https://www.mediawiki.org/wiki/Topic:Szqry8i5bnjeecjw)
I'd find it useful if the line detailing totals in message group statistics (random example) also stated directly how many languages are shown on the page (in that case, it would show a (22), when you suppress languages with 0% progress, when this task was first written).
Description
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add number of languages to message group stats table | mediawiki/extensions/Translate | master | +10 -5 |
Event Timeline
Yeah this seems relatively easy and uncontroversial. I suggest you rephrase it to say Totals for N shown languages or along that idea.
Change 380673 had a related patch set uploaded (by Omidfi; owner: Omidfi):
[mediawiki/extensions/Translate@master] Add number of languages to message group stats table
Hi,
Sorry if it's a noob question, but after I fixed the issues that came up in the code review, do I need to add a comment here, or I just need to wait?
It's okay to ping after some time if there isn't any sort of reply. We are not famous for fast code reviews, unfortunately.
Change 380673 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Add number of languages to message group stats table
Another noob question:
Who should close the tasks as resolved generally?
If I see my patch is merged shuould I just remove patch for review myself and put it on resolved?
If you know a place where I could find out answers to similar questions related to how I should use phabricator please let me know.
@Omidfi: Good question and hard to generalize. :) For most tasks, if everything has been done (patch has been merged, no backports planned etc) you can go ahead and set the task status to resolved. No need to remove Patch-For-Review, we normally don't care about that. Thanks for your patch!
@Nikerabbit is qqq the only non-language code? I am assuming it's being included, which isn't a big deal anyway.
qqq is a language code :) But it is not a real language, that's true. It is currently being counted, and I feel that's okay.
(For qqx and qqq info, see https://www.mediawiki.org/wiki/Manual:$wgDummyLanguageCodes#Details )