Maniphest T129924

Make FormatJson errors more understandable
Closed, ResolvedPublic
Actions

Description

Example diff to illustrate this problem: "<mapframe>: Syntax error" is not very user-friendly. "JSON syntax error" or something is needed.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Kartographer	master	+19 -3	Wrap JSON errors in a clarifyng message

Customize query in gerrit

Event Timeline

MaxSem created this task.Mar 14 2016, 9:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2016, 9:14 PM

Yurik added a project: Maps.Mar 14 2016, 11:27 PM

Restricted Application added a project: Discovery. · View Herald TranscriptMar 14 2016, 11:27 PM

Or a wrapper error like "Unable to parse GeoJSON: Syntax error"

Yurik moved this task from All map-related tasks to Kartographer on the Maps board.Mar 14 2016, 11:51 PM

Deskana moved this task from Needs triage to Maps on the Discovery board.Mar 15 2016, 3:39 AM

MaxSem moved this task from Backlog to To-do on the Maps-Sprint board.Jun 1 2016, 10:22 PM

MaxSem claimed this task.Jun 1 2016, 10:41 PM

Change 292295 had a related patch set uploaded (by MaxSem):
Wrap JSON erros in a clarifyng message

https://gerrit.wikimedia.org/r/292295

gerritbot added a project: Patch-For-Review.Jun 1 2016, 11:03 PM

MaxSem moved this task from To-do to Needs review on the Maps-Sprint board.Jun 1 2016, 11:04 PM

Change 292295 merged by jenkins-bot:
Wrap JSON errors in a clarifyng message

https://gerrit.wikimedia.org/r/292295

MaxSem closed this task as Resolved.Jun 3 2016, 6:00 PM

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)).Jun 8 2016, 3:01 PM