Page MenuHomePhabricator

npm tests constantly failing for oojs/ui changesets
Closed, ResolvedPublic

Description

npm tests have been constantly failing for oojs/ui changesets for a day or two now. Seems to be Karma failing.

Recent examples:

Event Timeline

You may want to upload a patch that debugs please.

Change 277593 had a related patch set uploaded (by Paladox):
Fix browser inactivity

https://gerrit.wikimedia.org/r/277593

Hi karma was part of the problem but not totally responsible see https://integration.wikimedia.org/ci/job/npm/58845/console please.

The tests were working on March the 11 so between then and now the tests broke.

Change 277614 had a related patch set uploaded (by Paladox):
Revert "testsuitegenerator: Always test empty values for 'string' type, not just for 'label'"

https://gerrit.wikimedia.org/r/277614

It's possible that https://gerrit.wikimedia.org/r/#/c/276216/ expanded the tests too much and karma can't cope now? The sticking point is mostly (but not always) FlaggedElement.test.js, immediately after JSPHP.test.js passes, but it's possible that the former causes karma to break/memory overflow/whatever?

Change 277752 had a related patch set uploaded (by Paladox):
Revert "testsuitegenerator: Test every triple of config options for ButtonWidget"

https://gerrit.wikimedia.org/r/277752

Change 277614 abandoned by Jforrester:
Revert "testsuitegenerator: Always test empty values for 'string' type, not just for 'label'"

Reason:
Not the issue.

https://gerrit.wikimedia.org/r/277614

Change 277752 abandoned by Jforrester:
Revert "testsuitegenerator: Test every triple of config options for ButtonWidget"

Reason:
Hah, sorry, made I7dbcea24 a few seconds earlier.

https://gerrit.wikimedia.org/r/277752

Change 277751 had a related patch set uploaded (by Jforrester):
Revert "testsuitegenerator: Test every triple of config options for ButtonWidget"

https://gerrit.wikimedia.org/r/277751

Change 277751 merged by jenkins-bot:
Revert "testsuitegenerator: Test every triple of config options for ButtonWidget"

https://gerrit.wikimedia.org/r/277751

Can this be closed as resolved please.

I suppose, it's still failing all the time, but for different reasons (T127100).