npm tests have been constantly failing for oojs/ui changesets for a day or two now. Seems to be Karma failing.
Recent examples:
npm tests have been constantly failing for oojs/ui changesets for a day or two now. Seems to be Karma failing.
Recent examples:
Hi karma was part of the problem but not totally responsible see https://integration.wikimedia.org/ci/job/npm/58845/console please.
Found the problem patch. It is https://gerrit.wikimedia.org/r/#/c/277278/ ive tested by doing it here https://gerrit.wikimedia.org/r/#/c/277604/
Change 277614 had a related patch set uploaded (by Paladox):
Revert "testsuitegenerator: Always test empty values for 'string' type, not just for 'label'"
Change 277593 abandoned by Paladox:
Fix browser inactivity
It's possible that https://gerrit.wikimedia.org/r/#/c/276216/ expanded the tests too much and karma can't cope now? The sticking point is mostly (but not always) FlaggedElement.test.js, immediately after JSPHP.test.js passes, but it's possible that the former causes karma to break/memory overflow/whatever?
Change 277752 had a related patch set uploaded (by Paladox):
Revert "testsuitegenerator: Test every triple of config options for ButtonWidget"
Change 277614 abandoned by Jforrester:
Revert "testsuitegenerator: Always test empty values for 'string' type, not just for 'label'"
Reason:
Not the issue.
Change 277752 abandoned by Jforrester:
Revert "testsuitegenerator: Test every triple of config options for ButtonWidget"
Reason:
Hah, sorry, made I7dbcea24 a few seconds earlier.
Change 277751 had a related patch set uploaded (by Jforrester):
Revert "testsuitegenerator: Test every triple of config options for ButtonWidget"
Change 277751 merged by jenkins-bot:
Revert "testsuitegenerator: Test every triple of config options for ButtonWidget"