Page MenuHomePhabricator
Create Task
Maniphest T130075

Move staging functions into helper classes
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

This is a small cleanup, to make staging functions more reusable between gateways and to reduce business logic clutter.

Details

Show related patches Customize query in gerrit

Event Timeline

awight created this task.Mar 15 2016, 9:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2016, 9:59 PM
awight added a project: Fundraising Sprint Elevator Maintenance 2016.Mar 15 2016, 10:01 PM
awight moved this task from Backlog to Doing on the Fundraising Sprint Elevator Maintenance 2016 board.
awight moved this task from Doing to Backlog on the Fundraising Sprint Elevator Maintenance 2016 board.
• DStrine added a project: Unplanned-Sprint-Work.Mar 15 2016, 10:07 PM
awight moved this task from Backlog to Doing on the Fundraising Sprint Elevator Maintenance 2016 board.Mar 15 2016, 11:03 PM
gerritbot subscribed.Mar 15 2016, 11:58 PM

Change 277698 had a related patch set uploaded (by Awight):
[WIP] Prototype encapsulation for staging functions

https://gerrit.wikimedia.org/r/277698

gerritbot added a project: Patch-For-Review.Mar 15 2016, 11:58 PM
• DStrine moved this task from Triage to Current Sprint & Completed in Q3 1516 on the Fundraising-Backlog board.Mar 16 2016, 3:53 PM
gerritbot added a comment.Mar 16 2016, 6:44 PM

Change 277698 merged by jenkins-bot:
Encapsulate staging functions

https://gerrit.wikimedia.org/r/277698

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)).Mar 16 2016, 7:00 PM
gerritbot added a comment.Mar 16 2016, 7:08 PM

Change 277705 had a related patch set uploaded (by Awight):
Encapsulate AstroPay staging methods

https://gerrit.wikimedia.org/r/277705

gerritbot added a comment.Mar 16 2016, 7:08 PM

Change 277845 had a related patch set uploaded (by Awight):
Generalize data transformations

https://gerrit.wikimedia.org/r/277845

• DStrine set the point value for this task to 2.Mar 16 2016, 10:44 PM
• DStrine added a project: Fundraising Sprint Freshmaking.Mar 16 2016, 10:55 PM
awight moved this task from Backlog to Doing on the Fundraising Sprint Freshmaking board.Mar 16 2016, 11:12 PM
awight claimed this task.Mar 17 2016, 12:28 AM
gerritbot added a comment.Mar 17 2016, 12:13 PM

Change 277936 had a related patch set uploaded (by Awight):
Encapsulate Ingenico staging functions

https://gerrit.wikimedia.org/r/277936

gerritbot added a comment.Mar 17 2016, 12:46 PM

Change 277979 had a related patch set uploaded (by Awight):
Clean up, add accessors

https://gerrit.wikimedia.org/r/277979

gerritbot added a comment.Mar 17 2016, 12:46 PM

Change 277978 had a related patch set uploaded (by Awight):
Put all extra transaction keys in submethod meta

https://gerrit.wikimedia.org/r/277978

gerritbot added a comment.Mar 17 2016, 12:46 PM

Change 277981 had a related patch set uploaded (by Awight):
Split ContributionTrackingPlusUnique into a reusable thing

https://gerrit.wikimedia.org/r/277981

gerritbot added a comment.Mar 17 2016, 12:46 PM

Change 277980 had a related patch set uploaded (by Awight):
Make BrazilianFiscalNumber staging reusable

https://gerrit.wikimedia.org/r/277980

gerritbot added a comment.Mar 17 2016, 12:46 PM

Change 277983 had a related patch set uploaded (by Awight):
Finish encapsulating Ingenico staging logic

https://gerrit.wikimedia.org/r/277983

gerritbot added a comment.Mar 17 2016, 12:46 PM

Change 277982 had a related patch set uploaded (by Awight):
Split out language staging

https://gerrit.wikimedia.org/r/277982

gerritbot added a comment.Mar 17 2016, 12:59 PM

Change 277985 had a related patch set uploaded (by Awight):
Encapsulate PayPal staging logic

https://gerrit.wikimedia.org/r/277985

gerritbot added a comment.Mar 17 2016, 8:08 PM

Change 277978 merged by jenkins-bot:
Put all extra transaction keys in submethod meta

https://gerrit.wikimedia.org/r/277978

gerritbot added a comment.Mar 17 2016, 8:08 PM

Change 277979 merged by jenkins-bot:
Clean up, add accessors

https://gerrit.wikimedia.org/r/277979

awight moved this task from Doing to Review on the Fundraising Sprint Freshmaking board.Mar 17 2016, 8:33 PM
awight added a subscriber: Ejegg.

I believe @Ejegg was looking at the Adyen staging functions, so I'm leaving those alone for now. The patches here are safe to merge individually.

gerritbot added a comment.Mar 17 2016, 10:54 PM

Change 277705 merged by jenkins-bot:
Encapsulate AstroPay staging methods

https://gerrit.wikimedia.org/r/277705

gerritbot added a comment.Mar 17 2016, 11:10 PM

Change 277845 merged by jenkins-bot:
Generalize data transformations

https://gerrit.wikimedia.org/r/277845

gerritbot added a comment.Mar 17 2016, 11:18 PM

Change 277936 merged by jenkins-bot:
Encapsulate Ingenico staging functions

https://gerrit.wikimedia.org/r/277936

gerritbot added a comment.Mar 22 2016, 10:21 PM

Change 277980 abandoned by Awight:
Make BrazilianFiscalNumber staging reusable

https://gerrit.wikimedia.org/r/277980

gerritbot added a comment.Mar 22 2016, 10:23 PM

Change 277981 abandoned by Awight:
Split ContributionTrackingPlusUnique into a reusable thing

https://gerrit.wikimedia.org/r/277981

gerritbot added a comment.Mar 22 2016, 10:29 PM

Change 277982 abandoned by Awight:
Split out language staging

https://gerrit.wikimedia.org/r/277982

gerritbot added a comment.Mar 25 2016, 9:31 PM

Change 277983 merged by jenkins-bot:
Finish encapsulating Ingenico staging logic

https://gerrit.wikimedia.org/r/277983

gerritbot added a comment.Mar 25 2016, 9:39 PM

Change 277985 merged by jenkins-bot:
Encapsulate PayPal staging logic

https://gerrit.wikimedia.org/r/277985

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)).Mar 25 2016, 10:00 PM
awight moved this task from Review to Pending Deployment on the Fundraising Sprint Freshmaking board.Mar 29 2016, 12:37 AM
awight moved this task from Pending Deployment to Done on the Fundraising Sprint Freshmaking board.Mar 30 2016, 12:02 AM
• DStrine moved this task from Current Sprint & Completed in Q3 1516 to Current Sprint & Completed in Q4 1516 on the Fundraising-Backlog board.Mar 30 2016, 10:07 PM
• DStrine added a project: Fundraising Sprint Ghostbusting .Mar 30 2016, 10:39 PM
• DStrine moved this task from Backlog to Done on the Fundraising Sprint Ghostbusting board.Mar 31 2016, 8:08 PM
awight added a comment.Apr 5 2016, 4:42 PM

@Ejegg
I'm happy to pick up the Adyen staging work whereever you leave it...

Ejegg closed this task as Resolved.Apr 5 2016, 8:58 PM
• DStrine removed a project: Unplanned-Sprint-Work.Apr 14 2016, 6:03 PM
Danny_B moved this task from Unsorted to Move on the Technical-Debt board.Apr 21 2016, 7:32 PM
• mmodell removed a subscriber: awight.Jun 22 2017, 9:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL