Page MenuHomePhabricator

Structured language overlay is not so structured
Closed, InvalidPublic1 Story Points

Description

Take a look at the following screenshot:

As I understand it there are two broad groups of languages: preferred and all. All languages has subgroups, i.e. languages with variants separated from the rest of the languages. The separation looks similar to how the two broad groups are separated. The headings and paddings above look the same. This makes me think that the languages with variants are not part of the all languages, and the languages that follow are not part of any grouping.

Solution:

Lets make the background color for the section header same as the cell (#FFF)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2016, 5:29 PM
Nirzar added a comment.EditedMar 16 2016, 11:38 PM

@bmansurov this is a good point and my first design solved this problem. I have been getting similar feedback about this.

what do you think of this?

but it created other problems such as what happens to languages once they go to the preferred group. lets talk about this in detail.

You're right indenting causes other problems. I'd just reduce the variant heading font and the space before it. Or event style it differently (no transparent background) so that it feels like part of the whole list.

Jdlrobson triaged this task as Normal priority.Mar 17 2016, 5:09 PM
Jdlrobson added a subscriber: Jdlrobson.

Nirzar to update description with what's required here.

Jdlrobson set the point value for this task to 1.Mar 22 2016, 4:45 PM
Nirzar updated the task description. (Show Details)

@Jdlrobson updated the description with the mock

We also need a mock when the language is not available in the general language (zh above). If that's the case we won't know the name of the general language and cannot display it.

@bmansurov doesn't the title suggest the parent language?

Never mind, I think I've found that the API returns the data we need.

bmansurov closed this task as Invalid.Mar 28 2016, 12:43 PM

I think we can close this task as we've removed variant headers in https://gerrit.wikimedia.org/r/#/c/279166/