Edits don't save in Visual editor at wikimaniawiki
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	Effeietsanders
	Mar 16 2016, 5:39 PM

Description

I have trouble saving edits in Visual Editor at (at least) Wikimania2016wiki. The problem exists a few weeks at least (I mentioned this a while back to James too - adding in cc), and I can reproduce it, but I don't have the problem on all pages:

go to a page like https://wikimania2016.wikimedia.org/wiki/Accommodation or https://wikimania2016.wikimedia.org/wiki/Volunteer
Click 'edit'
edit in VE
click 'save'
fill out summary or not
click save again
The page that is displayed now, does not contain the edit
saving through source does work fine.
a page that does save edits: https://wikimania2016.wikimedia.org/wiki/User:Effeietsanders/test and https://wikimania2016.wikimedia.org/wiki/User:Effeietsanders/test2

I have the problem in Chrome (logged in) and in Edge (anonymous).

Event Timeline

Effeietsanders created this task.Mar 16 2016, 5:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2016, 5:39 PM

This problem still exists, my edits on visual editor still don't save at Wikimaniawiki. I have not encountered the problem on other wikis.

I'm seeing the same problem as Effeietsanders.

I can reproduce this; a (non-destructive) way to show the behavior is to switch to source mode.
It could be related to the <translate> tags (a warning is shown -- this was possibly not the case yet a month ago?), but editing on e.g. https://www.mediawiki.org/wiki/Manual:Pywikibot works as expected.
However, if I copy the contents of https://wikimania2016.wikimedia.org/w/index.php?title=Accommodation to mediawiki.org, the same behavior returns! That suggests it's related to the specific contents of the page...

OK, found the cause after a bit of prodding. The issue is the use of templates in the <div> and <p> styles. I presume VE has trouble parsing those, and because the back-and-forth fails chooses not to edit at all? In any case, it should really tell you 'I don't understand this page, please edit in the old editor'.

This is my change that fixed it on my test page: https://www.mediawiki.org/w/index.php?title=User%3AValhallasw%2Ftest&type=revision&diff=2100620&oldid=2100619

valhallasw closed this task as a duplicate of T65941: VisualEditor: Support editing <div>s with mw:ExpandedAttrs due to a template in their style.Apr 17 2016, 7:06 PM

Edits don't save in Visual editor at wikimaniawikiClosed, DuplicatePublicActions

Description

Event Timeline

Edits don't save in Visual editor at wikimaniawiki
Closed, DuplicatePublic
Actions