Page MenuHomePhabricator

Remove unnecessary props from rcprop in RecentChangesPageGenerator
Closed, ResolvedPublic

Description

RecentChangesPageGenerator is requesting many other props which are unnecessary as they are not used. RecentChangesPageGenerator only uses title and type -- everything else is discarded. So there is a performance improvement which can be made to RecentChangesPageGenerator, by setting the rcprop to only include the props which are used.

Event Timeline

Tagged easy since this involves very minor changes.
Also, detailed discussion regarding this change was carried out in T129193.

We need to request only the title prop from rcprop, since type is taken care of by initialisation of a pywikibot.data.api.QueryGeneratorclass (gen_class) in APISite.recentchanges.

Adding this simple line in RecentChangesPageGenerator should do:

gen.request['rcprop'] = 'title'

Change 278085 had a related patch set uploaded (by Darthbhyrava):
Remove unnecessary props from rcprop in RecentChangesPageGenerator

https://gerrit.wikimedia.org/r/278085

Change 278085 merged by jenkins-bot:
Remove unnecessary props from rcprop in RecentChangesPageGenerator

https://gerrit.wikimedia.org/r/278085