RecentChangesPageGenerator is requesting many other props which are unnecessary as they are not used. RecentChangesPageGenerator only uses title and type -- everything else is discarded. So there is a performance improvement which can be made to RecentChangesPageGenerator, by setting the rcprop to only include the props which are used.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove unnecessary props from rcprop in RecentChangesPageGenerator | pywikibot/core | master | +1 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | darthbhyrava | T129193 reimplement imageuncat's -recentchanges as a pagegenerators command line argument | |||
| Resolved | darthbhyrava | T130189 Remove unnecessary props from rcprop in RecentChangesPageGenerator |
Event Timeline
Comment Actions
Tagged easy since this involves very minor changes.
Also, detailed discussion regarding this change was carried out in T129193.
Comment Actions
We need to request only the title prop from rcprop, since type is taken care of by initialisation of a pywikibot.data.api.QueryGeneratorclass (gen_class) in APISite.recentchanges.
Adding this simple line in RecentChangesPageGenerator should do:
gen.request['rcprop'] = 'title'
Comment Actions
Change 278085 had a related patch set uploaded (by Darthbhyrava):
Remove unnecessary props from rcprop in RecentChangesPageGenerator
Comment Actions
Change 278085 merged by jenkins-bot:
Remove unnecessary props from rcprop in RecentChangesPageGenerator