Should be possible to disable language button on certain Wikis
Closed, ResolvedPublic1 Estimate Story Points
Actions

Description

Many wikis do not have interwiki language links setup.
This includes 3rd parties, wikitech and mediawiki.org

Thus the new language switcher should be feature flagged, disabled by default and configured on.
This wasn't a problem with the old language switcher as if no languages were available it would be hidden, but with the new language switcher it is always shown.

You can demonstrate this by visiting any page in the mobile beta. Every page shows a disabled language switcher button.

Acceptance Criteria

Ensure this does not interfere with EventLogging logic for Main Page (T131093)
The feature flag and its default value are documented on-wiki

Details

Related Gerrit Patches:

mediawiki/extensions/MobileFrontend : master

Allow hiding the language button

Related Objects
Search...

Status	Assigned	Task
Declined	None	T104893 [EPIC]: Simplify navigation on mobile web
Open	None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
Resolved	ovasileva	T137932 [EPIC] Mobile language switching improvement work II
Resolved	• Nirzar	T129505 Ship mobile web readily available language button placement affordance on Wednesday immediately following Tuesday single-language deployment
Resolved	JKatzWMF	T121919 [GOAL] Improve in-article language switching on mobile web I
Resolved	None	T128350 Move mobile language switcher to top of the page and align article actions
Resolved	Jdlrobson	T130225 Should be possible to disable language button on certain Wikis
Resolved	dr0ptp4kt	T131287 Beta: unneeded horizontal lines on non-JS browsers

Event Timeline

Jdlrobson created this task.Mar 17 2016, 5:28 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMar 17 2016, 5:28 PM

@Nirzar if the button is disabled on a high percentage of pages but not actionable it arguably should be (e.g. allow people to start translations/invoke ContentTranslation cc @Amire80 ).

We had similar issues with the lead photo upload button so you may want to talk to @KHammerstein if you haven't already.

What is the "language button"? Definition please.

It looks like you might want to respect $wgULSPosition.

[...] wikis do not have interwiki language links setup. [...] wikitech and mediawiki.org

This is not correct.

Jdlrobson added projects: Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay, MobileFrontend-Feature-requests.Mar 23 2016, 10:55 PM

Jdlrobson updated the task description. (Show Details)

It's tricky because we bundle variants with the list of languages. Even if a wiki may not have interwiki language links it maybe available in other variants of the language.

What is the "language button"? Definition please.

It's the button you see to the right of the Title and the left of the watchstar on https://en.m.wikipedia.org/wiki/Sun?mobileaction=beta.

dr0ptp4kt set the point value for this task to 1.Mar 28 2016, 4:35 PM

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay board.Mar 28 2016, 4:35 PM

Jdlrobson assigned this task to bmansurov.Mar 28 2016, 10:14 PM

Jdlrobson removed bmansurov as the assignee of this task.

Jdlrobson updated the task description. (Show Details)

Jdlrobson triaged this task as Medium priority.Mar 28 2016, 10:16 PM

Jdlrobson edited projects, added MobileFrontend; removed MobileFrontend-Feature-requests.

Nemo_bis removed a subscriber: Nemo_bis.Mar 29 2016, 10:16 AM

bmansurov claimed this task.Mar 30 2016, 6:44 PM

bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay board.

Change 280498 had a related patch set uploaded (by Bmansurov):
Allow hiding the language button

https://gerrit.wikimedia.org/r/280498

gerritbot added a project: Patch-For-Review.Mar 30 2016, 7:37 PM

bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay board.Mar 30 2016, 7:37 PM

Allowing time for @phuedx and @jhobs to comment on what the default value should be in case we want to change it before signing off. To remind myself... If we want to default it to false, we'll need to write a config change as well (currently not needed)

Change 280498 merged by jenkins-bot:
Allow hiding the language button

https://gerrit.wikimedia.org/r/280498

bmansurov removed bmansurov as the assignee of this task.Mar 30 2016, 9:54 PM

I think default should be true. Encourages 3rd parties to think in multi-language and as long as it's well-documented on how to turn it off, I see no reason not to have it on by default.

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-05_(1.27.0-wmf.20)).Mar 31 2016, 9:02 AM

I'm OK with this feature being enabled by default; indeed, the "Read in another language" was introduced enabled by default.

I've updated the AC to include documenting the feature flag (MinervaAlwaysShowLanguageButton) on-wiki. I don't feel that this affects our original estimate.

Done.

phuedx updated the task description. (Show Details)Mar 31 2016, 9:19 AM

dr0ptp4kt added a subtask: T131287: Beta: unneeded horizontal lines on non-JS browsers.Mar 31 2016, 5:17 PM

bmansurov removed a project: Patch-For-Review.Apr 5 2016, 8:12 PM

Jdlrobson closed this task as Resolved.Apr 6 2016, 4:39 PM

Jdlrobson claimed this task.

Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay board.

dr0ptp4kt closed subtask T131287: Beta: unneeded horizontal lines on non-JS browsers as Resolved.Apr 8 2016, 2:56 PM