Page MenuHomePhabricator

"Select all" doesn't select pages created by a blocked user
Closed, ResolvedPublic

Description

Hi,

I've been deleting spam pages on my wiki using SmiteSpam, and it's been great, except for one big issue: when you "select all", it doesn't select the pages created by users who have already been blocked. This happens pretty regularly, because spam accounts that create a lot of pages will often have their spam pages spread out over multiple "screens" of the interface - and you can only select all their pages the first time.

Event Timeline

That's odd. Will look into this and fix ASAP. Thanks for reporting!

Change 278291 had a related patch set uploaded (by Polybuildr):
Fix select all/none to also account for pages created by blocked users

https://gerrit.wikimedia.org/r/278291

@Yaron_Koren, could you please check that the patch submitted works for you? After that, I'll merge. :)

@polybuildr - well, the "Select all" works now - but when I click on the "Smite spam" button, it doesn't do anything. And I don't see any JS or API errors. No idea why.

Let's move the patch's discussion to Gerrit. I've uploaded a new patch - should fix this.

Change 278291 merged by jenkins-bot:
Fix select all/none to also account for pages created by blocked users

https://gerrit.wikimedia.org/r/278291

Should be fixed now as long as the version you're using is master.