Page MenuHomePhabricator

Message group selector does not work in IE or Edge
Closed, ResolvedPublic

Description

Those browsers throw "Invalid argument" error when group selector is opened.

I isolated this to $( '<span>' ).prop( 'dir', 'auto' ); Changing prop to attr or auto to anything else makes the error go away.

Related Objects

Event Timeline

Do we actually need this? auto isn't very useful. Can't we make a better decision at this point in the code?

Change 279327 had a related patch set uploaded (by Nikerabbit):
Fix message group selector for IE/Edge

https://gerrit.wikimedia.org/r/279327

Change 279328 had a related patch set uploaded (by Nikerabbit):
Add a warning about T130390

https://gerrit.wikimedia.org/r/279328

Change 279330 had a related patch set uploaded (by Nikerabbit):
Fix interlanguage suggestions not showing up in IE/Edge

https://gerrit.wikimedia.org/r/279330

Change 279330 merged by jenkins-bot:
Fix interlanguage suggestions not showing up in IE/Edge

https://gerrit.wikimedia.org/r/279330

Change 279327 merged by jenkins-bot:
Fix message group selector for IE/Edge

https://gerrit.wikimedia.org/r/279327

Nikerabbit claimed this task.
Nikerabbit removed a project: Patch-For-Review.