Page MenuHomePhabricator
Create Task
Maniphest T130403

[2.1.143-alpha-2016-03-18] 'Find in page' cannot search collapsed tables
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

  1. Search for "find phrase" - in quotes. Two articles are listed: Richard Whately and Charles Sanders Peirce.
  2. Go to the either of the article and use 'Find in page' to search for find phrase (with or without quotes)
  3. 'Find in page' will return zero results.

Searching desktop wiki will show that 'find phrase' is in Notes which are collapsed in the app(the screenshot is from Richard Whately article).

Screen Shot 2016-03-18 at 12.36.31 PM.png (210×819 px, 79 KB)

  1. Uncollapse Notes and perform 'Find in page' search again - the 'find phrase' is found now.
  • Determine if PCS exposes a function to expand all tables at once (and if not, expose it).
  • Call the above function right before starting the search.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Create expandOrCollapseTables() method for find-in-page usage in the appmediawiki/services/mobileappsmaster+23 -8
Expose the toggleCollapsedForAll method for find-in-page usage in the appmediawiki/services/mobileappsmaster+14 -2
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Mar 18 2016, 7:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2016, 7:53 PM
Dbrant moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.Mar 25 2016, 2:59 PM
MBinder_WMF set the point value for this task to 1.May 18 2016, 7:48 PM
MBinder_WMF added a project: Android-app-Bugs.Oct 6 2016, 11:20 PM
• Niedzielski subscribed.Feb 13 2017, 7:33 PM

We use the native WebView find functionality. Perhaps this is a fundamental limitation of that approach?

RHo merged a task: T188811: Expand search feature in articles to the collapsed sections as well.Mar 6 2018, 5:30 PM
RHo added a subscriber: • Sharvaniharan.
Dbrant merged a task: T201882: Texts in collapsed tables are not searchable.Aug 13 2018, 11:23 PM
Dbrant added subscribers: cooltey, Android-app-Bugs.
Aklapper removed a subscriber: Android-app-Bugs.Mar 22 2020, 9:47 PM
Dbrant merged a task: T253494: find in page should search the whole page not just the visible portion.May 27 2020, 4:10 PM
Dbrant added a subscriber: jeremyb-phone.
Dbrant merged a task: T270232: "find in page" should match inside collapsed boxes/sections.Dec 16 2020, 12:53 PM
jeremyb-phone awarded a token.Dec 18 2020, 4:29 PM
• MattCleinman edited projects, added Wikipedia-Android-App-Backlog (Android Release FY2020-21); removed Wikipedia-Android-App-Backlog.Feb 25 2021, 12:58 AM
• MattCleinman moved this task from Epics in Progress to Ready for dev on the Wikipedia-Android-App-Backlog (Android Release FY2020-21) board.
Dbrant added subscribers: • MattCleinman, Dbrant.Feb 25 2021, 1:10 AM

@MattCleinman Is there a plan for how this would work?

• MattCleinman added a comment.Feb 25 2021, 1:21 AM

iOS uses a solution of expanding all tables when starting to search. Not perfect, but they like it more than potentially missing incidents of search terms.

Dbrant moved this task from Android Release FY2020-21 to Up Next on the Wikipedia-Android-App-Backlog board.Feb 25 2021, 1:30 PM
Dbrant edited projects, added Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Android Release FY2020-21).
LGoto triaged this task as Medium priority.Feb 25 2021, 5:14 PM
LGoto edited projects, added Wikipedia-Android-App-Backlog (Android Release FY2020-21); removed Wikipedia-Android-App-Backlog.Mar 1 2021, 5:51 PM
Dbrant updated the task description. (Show Details)Mar 1 2021, 5:55 PM
cooltey claimed this task.Mar 3 2021, 6:38 PM
cooltey moved this task from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android Release FY2020-21) board.
gerritbot added a comment.Mar 3 2021, 11:13 PM

Change 668226 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[mediawiki/services/mobileapps@master] Expose the toggleCollapsedForAll method for find-in-page usage in the app

https://gerrit.wikimedia.org/r/668226

gerritbot added a project: Patch-For-Review.Mar 3 2021, 11:13 PM
gerritbot added a comment.Mar 4 2021, 1:25 PM

Change 668226 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Expose the toggleCollapsedForAll method for find-in-page usage in the app

https://gerrit.wikimedia.org/r/668226

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2021, 2:11 PM
gerritbot added a comment.Mar 17 2021, 11:25 PM

Change 673156 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[mediawiki/services/mobileapps@master] Create expandOrCollapseTables() method for find-in-page usage in the app

https://gerrit.wikimedia.org/r/673156

gerritbot added a project: Patch-For-Review.Mar 17 2021, 11:25 PM
gerritbot added a comment.Mar 18 2021, 5:51 PM

Change 673156 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Create expandOrCollapseTables() method for find-in-page usage in the app

https://gerrit.wikimedia.org/r/673156

cooltey moved this task from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android Release FY2020-21) board.Mar 24 2021, 8:24 PM
cooltey moved this task from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android Release FY2020-21) board.Mar 26 2021, 6:41 PM
• scblr subscribed.Mar 29 2021, 2:58 PM

@cooltey please provide a link to the test apk for this. Also tried to test this the old fashioned way via Alpha but the link throws out a 404. Thanks.

• scblr moved this task from Design signoff to Did not pass QA on the Wikipedia-Android-App-Backlog (Android Release FY2020-21) board.Mar 29 2021, 3:00 PM
cooltey added a comment.EditedMar 31 2021, 6:36 PM

Hi @schoenbaechler

I forgot to add the HOLD tag on this PR so it has been merged to the master branch. In another word, you now can test it on the latest alpha APK.

Please note that when clicking on "find in article" button, all the hidden divs (e.g. info box) or sections (e.g. References) will be expanded.

• MattCleinman moved this task from Did not pass QA to QA signoff on the Wikipedia-Android-App-Backlog (Android Release FY2020-21) board.Mar 31 2021, 9:19 PM
ABorbaWMF moved this task from QA signoff to Ready for PM signoff on the Wikipedia-Android-App-Backlog (Android Release FY2020-21) board.Apr 2 2021, 4:45 PM
ABorbaWMF subscribed.

Looks good to me on 2.7.50349-alpha-2021-04-02

JTannerWMF moved this task from Ready for PM signoff to Ready for release on the Wikipedia-Android-App-Backlog (Android Release FY2020-21) board.Apr 5 2021, 2:57 PM
• Sharvaniharan closed this task as Resolved.Apr 13 2021, 5:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits