Page MenuHomePhabricator
Create Task
Maniphest T130459

Spaces entered in labels/ descriptions set via Special:NewItem not trimmed
Closed, ResolvedPublic
Actions

Description

Leading and trailing spaces in labels and descriptions set via Special:NewItem are not trimmed.

Aliases are handled correctly.

Details

SubjectRepoBranchLines +/-
Check for empty alias after trimming in SpecialNewEntitymediawiki/extensions/Wikibasemaster+13 -9
Trimming leading and trailing spaces in Special:NewItemmediawiki/extensions/Wikibasemaster+16 -9
Customize query in gerrit

Event Timeline

hoo created this task.Mar 19 2016, 2:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2016, 2:52 PM
hoo updated the task description. (Show Details)Mar 19 2016, 2:53 PM
xSavitar claimed this task.Mar 20 2016, 2:18 PM
gerritbot subscribed.Mar 20 2016, 2:32 PM

Change 278557 had a related patch set uploaded (by D3r1ck01):
Trimming leading and trailing spaces via Special:NewItem

https://gerrit.wikimedia.org/r/278557

gerritbot added a project: Patch-For-Review.Mar 20 2016, 2:32 PM
xSavitar moved this task from incoming to ready to go on the Wikidata board.Mar 20 2016, 2:51 PM
gerritbot added a comment.Mar 22 2016, 12:05 AM

Change 278557 merged by jenkins-bot:
Trimming leading and trailing spaces in Special:NewItem

https://gerrit.wikimedia.org/r/278557

gerritbot added a comment.Mar 22 2016, 11:20 AM

Change 278867 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Check for empty alias after trimming in SpecialNewEntity

https://gerrit.wikimedia.org/r/278867

thiemowmde added a project: Wikidata-Sprint-2016-03-01.Mar 22 2016, 11:20 AM
thiemowmde edited subscribers, added: thiemowmde; removed: gerritbot.
gerritbot added a comment.Mar 22 2016, 11:52 AM

Change 278867 merged by jenkins-bot:
Check for empty alias after trimming in SpecialNewEntity

https://gerrit.wikimedia.org/r/278867

xSavitar closed this task as Resolved.Apr 1 2016, 3:07 PM
Tobi_WMDE_SW moved this task from Proposed to Done on the Wikidata-Sprint-2016-03-01 board.Apr 11 2016, 12:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL