Page MenuHomePhabricator

Single Edit Tab "four choices" dialog doesn't go away when you exit the visual editor
Closed, ResolvedPublic1 Estimated Story Points


Steps to reproduce:

0) (Reset your preferences at if necessary.)

  1. Open a page in the visual editor. See the "four choices" dialog.
  2. Press the Escape key to exit the visual editor.
  3. Keep seeing the dialog box. (It still works, too.)

This is IMO unexpected behavior, but I'm not sure that it's actually unwanted behavior.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Escape key should close the dialog instead.

VE captures the escape key press when you have the document focused, the SET dialog captures it if you have the dialog focused.

We should probably ensure initial focus upon opening the dialog is the dialog

(It seems that we try, it's just that the edit surface finishes loading *afterwards*, stealing focus again)

Change 279081 had a related patch set uploaded (by Alex Monk):
Don't change focus to VE surface if we're opening the SET dialog

Change 279081 merged by jenkins-bot:
Don't change focus to VE surface if we're opening the SET dialog

Jdforrester-WMF assigned this task to AlexMonk-WMF.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.