Page MenuHomePhabricator
Create Task
Maniphest T130633

Alignment, space and shadow in language selector
Closed, ResolvedPublic
Actions

Assigned To
• santhosh
Authored By
kaldari
Mar 22 2016, 4:25 PM
Tags
Referenced Files
F3864180: pasted_file
Apr 12 2016, 6:44 AM
F3830983: pasted_file
Apr 5 2016, 6:22 AM
F3830981: pasted_file
Apr 5 2016, 6:22 AM
F3830673: pasted_file
Apr 5 2016, 4:54 AM
F3691787: Screen Shot 2016-03-22 at 10.18.38 AM.png
Mar 22 2016, 4:25 PM
Subscribers
Aklapper
gerritbot
kaldari
Nikerabbit
Pginer-WMF
• santhosh

Description

BeforeAfter
Screen Shot 2016-03-22 at 10.18.38 AM.png (445×267 px, 52 KB)
pasted_file (505×658 px, 49 KB)

There are at least 4 problems evident in the above screenshot:

  1. There is no whitespace between the "Edit links" link and the "16 more" button.
  2. The arrow for the pop-up dialog doesn't line up with "16 more" button.
  3. There is no whitespace between the magnifying glass and the edge of the pop-up dialog.
  4. The pop-up dialog has a drop shadow but the arrow doesn't.

This screenshot was taken in Firefox 45, but it looks the same in Chrome and Safari. URL is https://en.wikipedia.org/wiki/Nadiya_Savchenko while logged in.

Details

SubjectRepoBranchLines +/-
Correct the position the arrow of selector and add shadowmediawiki/extensions/UniversalLanguageSelectormaster+52 -31
Add left and right padding for search header of compact ULSmediawiki/extensions/UniversalLanguageSelectormaster+1 -1
Compact links: Add margin to the bottom of n more buttonmediawiki/extensions/UniversalLanguageSelectormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

kaldari created this task.Mar 22 2016, 4:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2016, 4:25 PM
kaldari updated the task description. (Show Details)Mar 22 2016, 4:27 PM
kaldari updated the task description. (Show Details)
KartikMistry added a project: UniversalLanguageSelector.Mar 22 2016, 4:32 PM
• santhosh subscribed.Mar 23 2016, 5:24 AM
Amire80 edited projects, added ULS-CompactLinks; removed Language-Team.Mar 23 2016, 6:33 AM
Pginer-WMF subscribed.Mar 23 2016, 7:59 AM

There is no whitespace between the magnifying glass and the edge of the pop-up dialog.

This may be related to T85997: Language selector search and close icons misplaced

Nemo_bis subscribed.Mar 25 2016, 8:28 AM

What is the "Interlanguage interface"?

Nemo_bis renamed this task from Interlanguage interface is a mess to Alignment, space and shadow in language selector.Mar 25 2016, 8:29 AM
Nemo_bis triaged this task as Low priority.
Amire80 moved this task from Backlog to Appearance and design on the ULS-CompactLinks board.Mar 26 2016, 3:56 PM
• santhosh added a parent task: T66793: Make compact interlanguage links default.Mar 29 2016, 5:29 AM
Amire80 added a project: Language-Engineering April-June 2016.Mar 30 2016, 8:50 AM
Nikerabbit moved this task from Backlog to ULS on the Language-Engineering April-June 2016 board.Mar 30 2016, 8:50 AM
Nemo_bis removed a parent task: T66793: Make compact interlanguage links default.Apr 2 2016, 9:06 AM

I removed an unexplained dependency.

kaldari added a comment.Apr 4 2016, 9:36 PM

@Nemo_bis: Unless you're actually going to work on this bug (or are managing people that are), please do not set the priority.

kaldari raised the priority of this task from Low to Needs Triage.Apr 4 2016, 9:36 PM
gerritbot subscribed.Apr 5 2016, 4:53 AM

Change 281593 had a related patch set uploaded (by Santhosh):
Add left and right padding for search header of compact ULS

https://gerrit.wikimedia.org/r/281593

gerritbot added a project: Patch-For-Review.Apr 5 2016, 4:53 AM
• santhosh added a comment.Apr 5 2016, 4:54 AM

With https://gerrit.wikimedia.org/r/281593 padding of search icon fixed

pasted_file (412×530 px, 39 KB)

• santhosh claimed this task.Apr 5 2016, 4:54 AM
• santhosh triaged this task as Medium priority.
• santhosh added a project: Language-Q4-2016-Sprint 2.
• santhosh edited projects, added Language-Q4-2016-Sprint 1; removed Language-Q4-2016-Sprint 2.Apr 5 2016, 5:10 AM
• santhosh moved this task from Backlog to In Review on the Language-Q4-2016-Sprint 1 board.
gerritbot added a comment.Apr 5 2016, 5:13 AM

Change 281594 had a related patch set uploaded (by Santhosh):
Compact links: Add margin to the bottom of n more button

https://gerrit.wikimedia.org/r/281594

gerritbot added a comment.Apr 5 2016, 6:21 AM

Change 281595 had a related patch set uploaded (by Santhosh):
Correct the vertical poosition the arrow of selector and add shadow

https://gerrit.wikimedia.org/r/281595

• santhosh added a comment.Apr 5 2016, 6:22 AM

After correcting the arrow.
LTR:

pasted_file (474×721 px, 55 KB)

RTL
pasted_file (468×719 px, 38 KB)

gerritbot added a comment.Apr 5 2016, 6:30 AM

Change 281594 merged by jenkins-bot:
Compact links: Add margin to the bottom of n more button

https://gerrit.wikimedia.org/r/281594

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-05_(1.27.0-wmf.20)).Apr 5 2016, 7:00 AM
gerritbot added a comment.Apr 6 2016, 6:47 AM

Change 281593 abandoned by Nikerabbit:
Add left and right padding for search header of compact ULS

Reason:
Done in I52215676f20b

https://gerrit.wikimedia.org/r/281593

gerritbot added a comment.Apr 6 2016, 12:16 PM

Change 281595 merged by jenkins-bot:
Correct the position the arrow of selector and add shadow

https://gerrit.wikimedia.org/r/281595

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-12_(1.27.0-wmf.21)).Apr 6 2016, 1:00 PM
Nikerabbit subscribed.Apr 7 2016, 12:35 PM

https://github.com/wikimedia/jquery.uls/pull/212 is for this and needs review.

Nemo_bis unsubscribed.Apr 7 2016, 5:05 PM
• santhosh moved this task from In Review to QA on the Language-Q4-2016-Sprint 1 board.Apr 11 2016, 5:01 AM
Nikerabbit added a comment.Apr 12 2016, 6:44 AM

pasted_file (505×658 px, 49 KB)
Screenshot from http://en.wikipedia.beta.wmflabs.org/wiki/Aquarium. As far as I can see all the reported issues have been fixed.

Nikerabbit removed a project: Patch-For-Review.Apr 12 2016, 6:46 AM
Nikerabbit updated the task description. (Show Details)
Nikerabbit moved this task from QA to Done on the Language-Q4-2016-Sprint 1 board.
Pginer-WMF mentioned this in T132424: Adjust the magnifying glass icon on the language selector.Apr 12 2016, 8:40 AM
Pginer-WMF added a comment.Apr 12 2016, 8:44 AM
In T130633#2198017, @Nikerabbit wrote:

pasted_file (505×658 px, 49 KB)
Screenshot from http://en.wikipedia.beta.wmflabs.org/wiki/Aquarium. As far as I can see all the reported issues have been fixed.

This is great. However, the size of the magnifying glass icon seems a bit unbalanced with respect to the text.
I created a separate ticket for this: T132424: Adjust the magnifying glass icon on the language selector

kaldari closed this task as Resolved.Apr 13 2016, 3:04 AM

Nice work guys! That's a big improvement.

Amire80 moved this task from Backlog to Appearance and design on the UniversalLanguageSelector board.Nov 3 2017, 8:51 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL