Maniphest T130648

Structured Language Overlay extra whitespace
Closed, ResolvedPublic
Actions

Description

When filtering is in effect, there is some space before the filtered results on the structured language overlay. It happens on Firefox and Chrome on Android.

Expected: No space before the filtered results.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/MobileFrontend	master	+2 -2	Remove unnecessary whitespace from LanguageOverlay

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		JKatzWMF	T121919 [GOAL] Improve in-article language switching on mobile web I
		Resolved		dr0ptp4kt	T129274 Ship mobile web structured language modal overlay
		Resolved		bmansurov	T130648 Structured Language Overlay extra whitespace

Event Timeline

bmansurov created this task.Mar 22 2016, 5:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2016, 5:54 PM

Jdlrobson triaged this task as High priority.Mar 23 2016, 5:13 PM

Jdlrobson added a project: Reading-Web-Sprint-68-"Java and JavaScript are basically the same".

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.

Change 279251 had a related patch set uploaded (by Bmansurov):
Remove unnecessary whitespace from LanguageOverlay

https://gerrit.wikimedia.org/r/279251

gerritbot added a project: Patch-For-Review.Mar 23 2016, 9:30 PM

bmansurov moved this task from To Do to Code Review on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.Mar 23 2016, 10:07 PM

phuedx assigned this task to bmansurov.Mar 24 2016, 10:46 AM

Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.Mar 24 2016, 9:59 PM

Change 279251 merged by jenkins-bot:
Remove unnecessary whitespace from LanguageOverlay

https://gerrit.wikimedia.org/r/279251

Verified on http://reading-web-staging.wmflabs.org

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)).Mar 24 2016, 11:00 PM

dr0ptp4kt added a parent task: T129274: Ship mobile web structured language modal overlay.Mar 25 2016, 7:30 PM