Page MenuHomePhabricator

Multiple redirects to the same result throw an error
Closed, ResolvedPublic3 Estimated Story Points

Description

The search query for the letter 'h' results:

redirects": [
      {
        "index": 4,
        "from": "Humanities reference desk",
        "to": "Wikipedia:Reference desk/Humanities"
      },
...
      {
        "index": 5,
        "from": "Humanities Desk",
        "to": "Wikipedia:Reference desk/Humanities"
      }],
"pages": {
      "2535875": {
        "pageid": 2535875,
        "ns": 4,
        "title": "Wikipedia:Reference desk/Humanities",
        "index": 4
      }
/* index 5 doesn't exist */
}

When a search query returns multiple redirects that point to the same page, some of the redirects may have invalid an 'index' value. This currently throws a JS error.

Event Timeline

Jdrewniak set the point value for this task to 3.Mar 22 2016, 7:26 PM

Change 278968 had a related patch set uploaded (by Jdrewniak):
Escapes search strings for use in regexp. Also fixes T130657, by filtering results array to remove undefined values.

https://gerrit.wikimedia.org/r/278968

Change 278968 merged by jenkins-bot:
Escapes search strings for use in regexp. Also fixes T130657 by skipping undefined values when generating typeahead template.

https://gerrit.wikimedia.org/r/278968