Page MenuHomePhabricator

Visual editor Template tool should not show deprecated parameter(s), unless already has value
Closed, DuplicatePublic

Description

synopsis says it all.

RATIONALE
The template tool should, of course, show deprecated parameters which already have values, but showing empty deprecated parameters, is counter-productive.
Marking them with a tiny grey circle with exclamation point is hardly a sufficient excuse.

REPRODUCTION

  1. select some test template
  2. add a field to this template, and mark it as "deprecated"
  3. using VE, add this template to a page. note that template tool offers to assign value to the deprecated parameter.

TESTING AFTER THE FIX

  1. select some test template
  2. add a field named "oldparam" to this template, and mark it as "deprecated"
  3. using VE, add this template to a page. make sure the template tool *does not* show the deprecated parameter.
  4. save page
  5. use source-code editor, add this parameter to the template with empty value ( | oldparam = | nextparam = ... )
  6. using VE, edit the template. make sure the tool tool *does not* show the deprecated parameter.
  7. use source-code editor, add this parameter to the template with non-empty value ( | oldparam = oldvalue | ... )
  8. using VE, edit the template. make sure the tool *does* show the deprecated parameter and its value, while marking it "deprecated"

peace.