Page MenuHomePhabricator
Create Task
Maniphest T130689

Google's services should load data-mw from a separate API call to RESTBase
Open, MediumPublic0 Estimated Story Points
Actions

Description

Work is ongoing in Parsoid and RESTBase to remove data-mw from being an inlined HTML attribute. Accordingly, Google's services should be updated to fetch data-mw in a separate API call from RESTBase. Once this change is live on the RESTBase end, the version string in the Accept: header based on the changes in T130638: Add data-mw as a separate JSON blob in the pagebundle output of Parsoid's API to get the updated HTML without inlined data-mw.

Since Google is a high-traffic API client of Parsoid HTML, in order to minimize the performance impact in the Parsoid production cluster from having to convert the latest version to the previous version, please try to prioritize this work so that you can enable this change within a short time of this change being live on the RESTBase end.

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
OpenNoneT130639 All known clients of Parsoid HTML that require data-mw should fetch data-mw separately (if using RESTBase) or process the data-mw blob in Parsoid's pagebundle API response (if using Parsoid directly)
OpenNoneT130689 Google's services should load data-mw from a separate API call to RESTBase
· · ·

Event Timeline

ssastry created this task.Mar 23 2016, 12:48 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2016, 12:48 AM
ssastry added projects: Parsoid, RESTBase.Mar 23 2016, 12:48 AM
Krenair subscribed.Mar 23 2016, 1:10 AM
Renxiaoyi added a comment.Mar 23 2016, 2:02 AM

Ack. When will this happen? And will you keep inlined data-mw in HTML returned by /transform/wikitext/to/html endpoint?

ssastry added a comment.Mar 23 2016, 2:35 PM

About ~3-4 weeks before the code is ready for deploy on the Parsoid and RESTBase end. However, this will be enabled in production once we have a sense of what kind of performance impacts we are looking at supporting the older version, and if there are any blockers from clients.

ssastry added subscribers: • mobrovac, • GWicke.Mar 23 2016, 2:37 PM
In T130689#2143332, @Renxiaoyi wrote:

And will you keep inlined data-mw in HTML returned by /transform/wikitext/to/html endpoint?

Good question regarding /transform/wikitext/to/html endpoint. I'll let @mobrovac and @GWicke answer that question.

Looking at the current behavior for data-parsoid which is already being stripped out by Parsoid,

[subbu@earth notes] curl -X POST --header 'Content-Type: application/x-www-form-urlencoded' --header 'Accept: text/html; charset=utf-8; profile="mediawiki.org/specs/html/1.2.0"' -d 'wikitext=\u0027\u0027foo\u0027\u0027%20and%20%0A*bar%0Aand%20%7B%7Becho%7Cboo%7D%7D' 'https://en.wikipedia.org/api/rest_v1/transform/wikitext/to/html'
<!DOCTYPE html>
<html prefix="dc: http://purl.org/dc/terms/ mw: http://mediawiki.org/rdf/"><head prefix="mwr: http://en.wikipedia.org/wiki/Special:Redirect/"><meta property="mw:articleNamespace" content="0"/><meta property="mw:html-content-type" content='text/html; charset=utf-8; profile="mediawiki.org/specs/html/1.2.0"'/><link rel="dc:isVersionOf" href="//en.wikipedia.org/wiki/Main_Page"/><title></title><base href="//en.wikipedia.org/wiki/"/><link rel="stylesheet" href="//en.wikipedia.org/w/load.php?modules=mediawiki.legacy.commonPrint,shared|mediawiki.skinning.elements|mediawiki.skinning.content|mediawiki.skinning.interface|skins.vector.styles|site|mediawiki.skinning.content.parsoid|ext.cite.style&amp;only=styles&amp;skin=vector"/></head><body id="mwAA" lang="en" class="mw-content-ltr sitedir-ltr ltr mw-body mw-body-content mediawiki" dir="ltr"><p id="mwAQ">\u0027\u0027foo\u0027\u0027 and </p>
<ul id="mwAg"><li id="mwAw">bar</li></ul>
<p id="mwBA">and <span about="#mwt1" typeof="mw:Transclusion" id="mwBQ" data-mw='{"parts":[{"template":{"target":{"wt":"echo","href":"./Template:Echo"},"params":{"1":{"wt":"boo"}},"i":0}}]}'

So, looks like RESTBase is querying the http://<parsoid>/<domain>/v3/transform/wikitext/to/pagebundle endpoint (and returning only the html bundle) instead of querying the http://<parsoid>/<domain>/v3/transform/wikitext/to/html endpoint. I think RESTBase should be using the latter endpoint for its /transform/wikitext/to/html requests in which case data-parsoid and data-mw will continue to be inlined.

Renxiaoyi added a comment.Mar 24 2016, 1:04 AM

Thanks. For our use case it will be easier if /transform/wikitext/to/html keeps data-mw inlined in result HTML.

• GWicke added a project: Services.Oct 12 2016, 11:18 PM
• GWicke moved this task from Backlog to later on the Services board.Jul 11 2017, 7:55 PM
• GWicke edited projects, added Services (later); removed Services.
• GWicke moved this task from later to watching on the Services board.
• GWicke edited projects, added Services (watching); removed Services (later).
ssastry moved this task from Needs Triage to Section-Editing-Support on the Parsoid board.Apr 10 2018, 8:07 PM
ssastry edited projects, added Parsoid (Section-Editing-Support); removed Parsoid.
ssastry added a project: Parsoid-Edit-Support.Sep 20 2018, 4:30 PM
ssastry edited projects, added Parsoid-Edit-Support (Subtree Editing Support); removed Parsoid-Edit-Support, Parsoid (Section-Editing-Support).Sep 20 2018, 5:11 PM
• mobrovac added a project: Platform Team Legacy (Watching / External).Dec 20 2018, 12:04 PM
Aklapper added a comment.Jul 20 2019, 5:24 PM

@Renxiaoyi: Hi! You assigned this task to yourself a while ago. Could you maybe share a status update? Are you still working (or still plan to work) on this issue? Or is there anything that others could help with? (If you do not plan to work on this issue anymore, please remove yourself as assignee (via Add Action... → Assign / Claim in the dropdown menu) so others could work on it.) Thanks a lot!

ssastry added a subscriber: • Andre.Jul 20 2019, 5:29 PM
In T130689#5351169, @Aklapper wrote:

@Renxiaoyi: Hi! You assigned this task to yourself a while ago. Could you maybe share a status update? Are you still working (or still plan to work) on this issue? Or is there anything that others could help with? (If you do not plan to work on this issue anymore, please remove yourself as assignee (via Add Action... → Assign / Claim in the dropdown menu) so others could work on it.) Thanks a lot!

@Andre, this is blocked on RESTBase + Parsoid. We haven't turned on this feature yet for a bunch of reasons. So, nothing for any of the clients to do yet.

Aklapper changed the task status from Open to Stalled.Nov 25 2019, 12:48 AM

Setting task status to stalled as per ssastry's last comment.

Aklapper mentioned this in T228575: Decrease number of open tickets with assignee field set for more than two years (aka cookie licking) (March-June 2020 edition).Nov 30 2019, 10:52 PM
Aklapper edited projects, added Parsoid; removed Parsoid-Edit-Support (Subtree Editing Support).Feb 29 2020, 5:15 PM
Aklapper removed Renxiaoyi as the assignee of this task.Feb 3 2022, 2:17 PM
Aklapper edited subscribers, added: Renxiaoyi; removed: • Andre, • GWicke, • mobrovac.

@ssastry: Two years later, Is there a ticket about turning on this feature in RESTBase + Parsoid, that this task should depend on?

Boldly removing assignee as this task does not look actionable currently.

Aklapper changed the task status from Stalled to Open.Dec 29 2023, 12:57 PM

@ssastry: No reply; resetting status.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits