Page MenuHomePhabricator
Create Task
Maniphest T130720

Have load.php set $wgLang and the RequestContext language
Closed, DeclinedPublic
Actions

Description

There are devious code paths that can still depend on the user preference language no matter how much we try to clean things up, for example Title::getMainPage() when $wgForceUIMsgAsContentMsg contains 'mainpage'.

The only sensible fix is to set the main RequestContext language (and $wgLang) to the ResourceLoader language in load.php.

(T127920: Message class should use appropiate default language based on request context was supposed to be about doing this, but it wound up instead shaving a yak that didn't even need to be shaved.)

Details

SubjectRepoBranchLines +/-
Have load.php use the RL language, not the user's preference languagemediawiki/coremaster+7 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Anomie created this task.Mar 23 2016, 3:03 PM
gerritbot added a comment.Mar 23 2016, 3:03 PM

Change 279122 had a related patch set uploaded (by Anomie):
Have load.php use the RL language, not the user's preference language

https://gerrit.wikimedia.org/r/279122

gerritbot added a project: Patch-For-Review.Mar 23 2016, 3:03 PM
Krinkle added a comment.Mar 23 2016, 10:14 PM

Any code relating to RequestContext (including Title::getMainPage() and MediaWiki components) have no business being executed in a load.php request. If that happens, that is an error that may result in cache poisoning due to it being cached and run based on context (not necessarily the global context due to cascading updates and faux requests via OutputPage, StartupModule and other places) and a violation of separation in general for making ResourceLoader more standalone (stretch goal, but design principle nonetheless to not explicitly encourage coupling).

Anomie added a comment.Mar 23 2016, 10:51 PM

Well, Title::getMainPage() is called from ResourceLoaderStartUpModule, and has been since a long time ago, so you might want to look into that.

Krinkle added a comment.Apr 12 2016, 10:43 PM

Fixed in 67984c30d63b1b.

gerritbot added a comment.Apr 18 2016, 8:55 PM

Change 279122 abandoned by Anomie:
Have load.php use the RL language, not the user's preference language

Reason:
Not needed now.

https://gerrit.wikimedia.org/r/279122

Anomie closed this task as Declined.Apr 18 2016, 8:55 PM

Decided to go a different way.

Anomie mentioned this in T134562: SMW triggers "Sessions are disabled for this entry point".May 10 2016, 1:38 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL