Page MenuHomePhabricator
Create Task
Maniphest T130793

Cross-wiki notifications are underlined when underline links preference is enabled
Closed, ResolvedPublic
Actions

Description

If you go to Preferences -> Appearance and set "Link underlining" to "Always", local notification items (correctly) aren't underlined, but cross-wiki notifications (incorrectly) are.

notifs-underlined.png (465×540 px, 53 KB)

(Thanks to @Jdforrester-WMF for finding this bug)

Details

SubjectRepoBranchLines +/-
Apply text-decoration: none; on non-hover as wellmediawiki/extensions/Echomaster+2 -0
Customize query in gerrit

Event Timeline

Catrope created this task.Mar 23 2016, 11:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2016, 11:12 PM
gerritbot subscribed.Mar 23 2016, 11:13 PM

Change 279281 had a related patch set uploaded (by Catrope):
Apply text-decoration: none; on non-hover as well

https://gerrit.wikimedia.org/r/279281

gerritbot added a project: Patch-For-Review.Mar 23 2016, 11:13 PM
Catrope moved this task from Untriaged to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Mar 23 2016, 11:55 PM
Jdforrester-WMF assigned this task to Catrope.Mar 24 2016, 12:01 AM
Jdforrester-WMF triaged this task as Low priority.
gerritbot added a comment.Mar 24 2016, 1:04 AM

Change 279281 merged by jenkins-bot:
Apply text-decoration: none; on non-hover as well

https://gerrit.wikimedia.org/r/279281

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)).Mar 24 2016, 2:00 AM
• jmatazzoni added a project: Collab-Team-2016-Apr-Jun-Q4.Apr 6 2016, 10:23 PM
• jmatazzoni moved this task from Untriaged to Needs Review on the Collab-Team-2016-Apr-Jun-Q4 board.Apr 6 2016, 10:28 PM
SBisson moved this task from Needs Review to QA Review on the Collab-Team-2016-Apr-Jun-Q4 board.Apr 7 2016, 12:35 PM
Etonkovidova subscribed.Apr 8 2016, 10:36 PM

Checked the fix in betalabs - no underlined links (the screenshot is for the case reported in the ticket)

Screen Shot 2016-04-08 at 3.24.42 PM.png (370×620 px, 63 KB)

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-2016-Apr-Jun-Q4 board.Apr 8 2016, 10:36 PM
• jmatazzoni closed this task as Resolved.Apr 8 2016, 11:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL