Page MenuHomePhabricator

In WDQS GUI, each keystroke now produces new history entry
Closed, ResolvedPublic

Description

When I edit query in WDQS GUI, each time I change something, new history entry is produced, so that if I type a lot there is a huge number of history entries generated.

This is inconvenient and confusing. I'd say instead new history entry should be produced when the query is run and when new query is started, such as by clean or opening new window, otherwise it should be replaced.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

It actually breaks the history for me, I can press the back button once and it deletes the last letter I typed, but pressing it again does nothing (in all the browsers I tried, including two versions of Chromium, Firefox and Vivaldi).

Another problem which I'm assuming is also caused by this (since it updates the URL on every keystroke) is that after I run a query in Chromium or Vivaldi (presumably any Blink-based ones), typing in the textarea is laggy. I couldn't reproduce it in Firefox and aude couldn't reproduce it at all, but it happens on both of my computers on all the queries I've tried so far (it seems to be worse after queries returning lots of results, so maybe try something like https://query.wikidata.org/#SELECT%20%3Fitem%20WHERE%20%7B%0A%3Fitem%20wdt%3AP17%20wd%3AQ17%0A%7D%20limit%2010000 if you want to see if you can reproduce it)

Change 280175 had a related patch set uploaded (by Jonas Kress (WMDE)):
Removes URL change an editor change

https://gerrit.wikimedia.org/r/280175

Change 280175 merged by jenkins-bot:
Removes URL change an editor change

https://gerrit.wikimedia.org/r/280175

Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.