Create some tests for pywikibot.diff.PatchManager
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jayvdb
	Mar 24 2016, 2:09 AM

Description

The function pywikibot.showDiff is an important part of the pywikibot UI, allowing users to quickly review proposed changes to be made. It uses color to maximise the amount of information that can be shown to the user on a text interface to help them make their decision.
The logic behind this function was migrated to pywikibot.diff.PatchManager and radically improved , and the switch to using PatchManager occurred in ce6e10ba.

However the module pywikibot.diff only has tests in diff_tests for T134341 (3c8c5eae24a14)

Some very basic tests should be created. There are a lot of interesting test scenarios on https://test.wikipedia.org/wiki/User:John_Vandenberg/diff_test (see T130572 for how to use it)

See documentation in tests/README.rst.

Then it is easier to add new tests when bugs are being fixed (e.g. T130572) and enhancements are added.

This should be an good first task task for a newbie.

Details

	Subject	Repo	Branch	Lines +/-
	Added tests for cherry_pick function of diff module	pywikibot/core	master	+71 -1
	Basic PatchManager unit tests	pywikibot/core	master	+86 -2

Customize query in gerrit

Related Objects

Mentioned Here: T134341: Create tests for diff.html_comparator
rPWBCce6e10ba797f: [FEAT] Diff: Use PatchManager for showDiff
rPWBC3c8c5eae24a1: tests: Add pywikibot.diff.html_comparator() tests
T130572: Pywikibot diff highlights entire line when only text is removed

Event Timeline

jayvdb created this task.Mar 24 2016, 2:09 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptMar 24 2016, 2:09 AM

jayvdb moved this task from Backlog to New tests needed on the Pywikibot-tests board.Mar 24 2016, 2:10 AM

jayvdb renamed this task from pywikibot.diff has not tests to pywikibot.diff.PatchManager has no tests.May 16 2016, 1:52 AM

jayvdb updated the task description. (Show Details)

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMay 16 2016, 1:52 AM

jayvdb updated the task description. (Show Details)May 16 2016, 2:09 AM

Xqt triaged this task as Lowest priority.Aug 27 2016, 4:54 PM

Vennela0212 claimed this task.Oct 2 2016, 10:43 AM

Vennela0212 removed Vennela0212 as the assignee of this task.Oct 2 2016, 3:14 PM

Vennela0212 subscribed.

I will mentor this in Google-Code-In-2016

Aklapper renamed this task from pywikibot.diff.PatchManager has no tests to Create some tests for pywikibot.diff.PatchManager.Nov 27 2016, 10:24 PM

Imported as https://codein.withgoogle.com/tasks/5757373792649216/

Sn1per claimed this task.Nov 29 2016, 4:26 PM

Change 324724 had a related patch set uploaded (by Sn1per):
Basic PatchManager unit tests

https://gerrit.wikimedia.org/r/324724

gerritbot added a project: Patch-For-Review.Dec 1 2016, 2:23 PM

I was a little confused as to how to implement tests for the following from the diff_tests page:

{{}}Pywikipediabot{{{}}}
?
?{}Pywikipediabot?
+{yellow}Pywikipediabot
-{black}Pywikipediabot

Pywikipediabot{color}Pywikipediabot

{color}Pywikipediabot
{red}Pywikipediabot{red}

\03  foo Pywikibot    foo

%(foo)sPywikipediabot%(bar)s

You've looked through T130572?
Just do the ones you can, and supplement the tests with other types of interesting cases you can see will be helpful, even basic ones.

Change 324724 merged by jenkins-bot:
Basic PatchManager unit tests

https://gerrit.wikimedia.org/r/324724

jayvdb closed this task as Resolved.Dec 2 2016, 1:29 AM

AbdealiJK subscribed.Dec 2 2016, 4:15 AM

Note we currently have good coverage, but there are still some major component of the PatchManager which do not have any coverage at all.
See https://codecov.io/gh/wikimedia/pywikibot-core/src/ca11a4c4ceb6e7ae3363d97c99b4d46b1ede50a6/pywikibot/diff.py

Note I am leaving this task closed, but I have added instances to the GCI task to improve the coverage. Keep using this phab task as the gerrit task. Maybe we get to 100% before the end of GCI (but this task gets harder each time someone adds more tests).

matej_suchanek removed a project: Patch-For-Review.Jan 10 2017, 12:52 PM

Change 331576 had a related patch set uploaded (by Phantom42):
Added tests for cherry_pick function of diff module

https://gerrit.wikimedia.org/r/331576

gerritbot added a project: Patch-For-Review.Jan 11 2017, 4:43 AM

Change 331576 merged by jenkins-bot:
Added tests for cherry_pick function of diff module

https://gerrit.wikimedia.org/r/331576