Page MenuHomePhabricator

"Uncaught TypeError: Cannot read property 'equals' of null" when inserting Citoid-generated reference
Closed, ResolvedPublic1 Story Points

Description

Steps to reproduce:

  1. Open a page with the visual editor
  2. Open the citation tool
  3. Enter a URL (for example http://www.jstor.org/stable/2786878 )
  4. When the citation has been generated by Citoid, click "Insert"
  5. Nothing happens.

The console indicates:

Uncaught TypeError: Cannot read property 'equals' of null

ve.dm.LinearSelection.equals @ load.php?debug=false&lang=en&modules=ext.visualEditor.core|oojs-ui-core&skin=vector&version=7245fa0…:219
ve.dm.SurfaceFragment.update @ load.php?debug=false&lang=en&modules=ext.visualEditor.core|oojs-ui-core&skin=vector&version=7245fa0…:140
ve.dm.SurfaceFragment.change @ load.php?debug=false&lang=en&modules=ext.visualEditor.core|oojs-ui-core&skin=vector&version=7245fa0…:141
ve.dm.SurfaceFragment.insertContent @ load.php?debug=false&lang=en&modules=ext.visualEditor.core|oojs-ui-core&skin=vector&version=7245fa0…:150
ve.dm.MWTransclusionModel.insertTransclusionNode @ VM279:464
ve.ui.CiteFromIdInspector.onPreviewSelectWidgetChoose @ VM279:654
oo.EventEmitter.emit @ VM275:38
ve.ui.CiteFromIdGroupWidget.onItemInsert @ VM279:644
oo.EventEmitter.emit @ VM275:38
oo.EventEmitter.emit @ VM275:38
ve.ui.CiteFromIdReferenceWidget.onInsertButtonClick @ VM279:647
oo.EventEmitter.emit @ VM275:38OO
.ui.mixin.ButtonElement.onClick @ load.php?debug=false&lang=en&modules=ext.visualEditor.core|oojs-ui-core&skin=vector&version=7245fa0…:718
jQuery.event.dispatch @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=tbOYKAbm:65
elemData.handle @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=tbOYKAbm:60

Reproducible every time I try to add a reference on Meta, in Chromium 49.

Event Timeline

gpaumier created this task.Mar 24 2016, 5:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2016, 5:42 PM
Jdforrester-WMF triaged this task as Unbreak Now! priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added a subscriber: Neil_P._Quinn_WMF.

Change 279531 had a related patch set uploaded (by Esanders):
SurfaceFramgent: Guard against tx.getModifiedRange returning null

https://gerrit.wikimedia.org/r/279531

Change 279532 had a related patch set uploaded (by Jforrester):
SurfaceFramgent: Guard against tx.getModifiedRange returning null

https://gerrit.wikimedia.org/r/279532

Change 279531 merged by jenkins-bot:
SurfaceFramgent: Guard against tx.getModifiedRange returning null

https://gerrit.wikimedia.org/r/279531

Change 279532 merged by jenkins-bot:
SurfaceFramgent: Guard against tx.getModifiedRange returning null

https://gerrit.wikimedia.org/r/279532

This is not working on Beta cluster yet, not updated I guess?